stop persisting rejected blocks on P-chain #1696
Conversation
dhrubabasu
requested review from
abi87,
danlaine and
StephenButtolph
as code owners
| @@ -1486,11 +1488,11 @@ func (s *state) init(genesisBytes []byte) error { | |||
| return s.Commit() | |||
| } | |||
|
|
|||
| func (s *state) AddStatelessBlock(block blocks.Block, status choices.Status) { | |||
| func (s *state) AddStatelessBlock(block blocks.Block) { | |||
There was a problem hiding this comment.
nit: should we err if the block status is not actually accepted?
There was a problem hiding this comment.
We don't have that information here.
| AddStatelessBlock(block blocks.Block, status choices.Status) | ||
|
|
||
| // Invariant: [block] is an accepted block. | ||
| AddStatelessBlock(block blocks.Block) |
There was a problem hiding this comment.
nit: should we rename this AddStatelessAcceptedBlock for clarify? Maybe it's too long of name
There was a problem hiding this comment.
I feel like this change would be reverted when we remove status from GetStatelessBlock
|
@dhrubabasu also nit: we cannot yet remove the status from GetStatelessBlock right? Not until we purge rejected blocks |
We could make it so that Talked with Dhruba offline - going to leave this as part of the followup. |
Why this should be merged
Works towards resolving #1623
How this works
We only call
AddStatelessBlockwith accepted blocks, removing future rejected blocks from being persisted to memory or disk.Note: existing rejected blocks on disk are still there, a future PR will be made to prune them.
How this was tested
CI