nit

scripts/lint.sh

@@ -64,6 +64,13 @@ function test_require_equal_zero {
     echo ""
     return 1
   fi
+
+  if grep -R -zo -P 'require\.Equal\(.+?, (u?int\d+\(0\)|0)\)\n' .; then
+    echo ""
+    echo "Use require.Zero instead of require.Equal when testing for 0."
+    echo ""
+    return 1
+  fi
 }
 
 # Ref: https://go.dev/doc/effective_go#blank_implements

snow/networking/benchlist/benchlist_test.go

@@ -73,8 +73,8 @@ func TestBenchlistAdd(t *testing.T) {
 	require.False(t, b.isBenched(vdrID3))
 	require.False(t, b.isBenched(vdrID4))
 	require.Len(t, b.failureStreaks, 0)
-	require.Equal(t, b.benchedQueue.Len(), 0)
-	require.Equal(t, b.benchlistSet.Len(), 0)
+	require.Zero(t, b.benchedQueue.Len())
+	require.Zero(t, b.benchlistSet.Len())
 	b.lock.Unlock()
 
 	// Register [threshold - 1] failures in a row for vdr0
@@ -84,8 +84,8 @@ func TestBenchlistAdd(t *testing.T) {
 
 	// Still shouldn't be benched due to not enough consecutive failure
 	require.False(t, b.isBenched(vdrID0))
-	require.Equal(t, b.benchedQueue.Len(), 0)
-	require.Equal(t, b.benchlistSet.Len(), 0)
+	require.Zero(t, b.benchedQueue.Len())
+	require.Zero(t, b.benchlistSet.Len())
 	require.Len(t, b.failureStreaks, 1)
 	fs := b.failureStreaks[vdrID0]
 	require.Equal(t, threshold-1, fs.consecutive)
@@ -98,8 +98,8 @@ func TestBenchlistAdd(t *testing.T) {
 	// has passed since the first failure
 	b.lock.Lock()
 	require.False(t, b.isBenched(vdrID0))
-	require.Equal(t, b.benchedQueue.Len(), 0)
-	require.Equal(t, b.benchlistSet.Len(), 0)
+	require.Zero(t, b.benchedQueue.Len())
+	require.Zero(t, b.benchlistSet.Len())
 	b.lock.Unlock()
 
 	// Move the time up