Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce inlining functions with a single error return in require.NoError #1500

Merged
merged 71 commits into from
May 30, 2023
Merged
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
a2771ba
ban `require.Equal` when testing for `0`
dhrubabasu May 12, 2023
88f6841
Merge branch 'dev' into ban-require-equal-zero
dhrubabasu May 12, 2023
b065a98
ban usage of `require.Zero` when testing for length `0`
dhrubabasu May 12, 2023
0ccf063
Merge branch 'ban-require-equal-zero' into ban-require-zero-len
dhrubabasu May 12, 2023
fd714b1
add failing test
dhrubabasu May 12, 2023
d4d925b
fix
dhrubabasu May 12, 2023
e961d37
nit
dhrubabasu May 12, 2023
7aab521
Merge branch 'ban-require-zero-len' into ban-require-equal-len
dhrubabasu May 12, 2023
cfd7ca0
push
dhrubabasu May 12, 2023
946588a
ban usage of `nil` in require functions
dhrubabasu May 12, 2023
5fcf0f0
nit
dhrubabasu May 12, 2023
10dff95
fix regex
dhrubabasu May 12, 2023
9fdc7c5
nit
dhrubabasu May 12, 2023
c343bc9
Merge branch 'dev' into ban-require-equal-zero
StephenButtolph May 12, 2023
3dbdab1
merged
dhrubabasu May 12, 2023
5530818
Merge branch 'ban-require-zero-len' into ban-require-equal-len
dhrubabasu May 12, 2023
6b2a170
Merge branch 'ban-require-equal-len' into ban-require-nil
dhrubabasu May 12, 2023
421b72d
add comment
dhrubabasu May 12, 2023
0c919fd
match uint(0)
dhrubabasu May 12, 2023
f8c4359
Update scripts/lint.sh
dhrubabasu May 12, 2023
df6b971
Merge branch 'ban-require-equal-zero' into ban-require-zero-len
dhrubabasu May 12, 2023
4a37e01
merged
dhrubabasu May 12, 2023
7e40d38
nit
dhrubabasu May 12, 2023
fb10a1a
pr review
dhrubabasu May 12, 2023
7aadaf4
revert
dhrubabasu May 12, 2023
af4382d
nit
dhrubabasu May 12, 2023
5301a7d
nits
dhrubabasu May 12, 2023
e249d2b
reduce diff
dhrubabasu May 12, 2023
be82305
reduce diff
dhrubabasu May 12, 2023
8aa012d
reduce diff
dhrubabasu May 12, 2023
24fb051
nit
dhrubabasu May 12, 2023
7de1858
Merge branch 'ban-require-equal-len' into ban-require-nil
dhrubabasu May 12, 2023
dfeb84b
more nil checks
dhrubabasu May 12, 2023
7901762
wording
dhrubabasu May 12, 2023
2f1ba2d
regex nit
dhrubabasu May 12, 2023
90b376e
Merge branch 'ban-require-equal-len' into ban-require-nil
dhrubabasu May 12, 2023
4680df5
add linter
dhrubabasu May 13, 2023
e967771
fix
dhrubabasu May 13, 2023
ff94591
fix regex
dhrubabasu May 13, 2023
0aa2d36
moar
dhrubabasu May 13, 2023
720bfb0
nit
dhrubabasu May 13, 2023
b71ff1c
include multi-line functions
dhrubabasu May 13, 2023
31e4a37
should be good now
dhrubabasu May 13, 2023
c7226cf
moar
dhrubabasu May 13, 2023
e48fbb5
nit
dhrubabasu May 13, 2023
488d1a8
nit
dhrubabasu May 13, 2023
f17e674
fix
dhrubabasu May 13, 2023
a96a2d1
fix regex
dhrubabasu May 13, 2023
31fa556
merged
dhrubabasu May 15, 2023
5e3745a
Merge branch 'ban-require-zero-len' into ban-require-equal-len
StephenButtolph May 15, 2023
6709b1c
Update scripts/lint.sh
dhrubabasu May 16, 2023
5d2f1e2
Update scripts/lint.sh
dhrubabasu May 16, 2023
0457148
Merge branch 'dev' into ban-require-zero-len
dhrubabasu May 16, 2023
f4f0c15
nit
dhrubabasu May 16, 2023
62d168e
nit
dhrubabasu May 16, 2023
e7cf371
regex is easy they said
dhrubabasu May 16, 2023
b9d80b3
revert regex changes
dhrubabasu May 16, 2023
d1d0fdc
revert window change
dhrubabasu May 16, 2023
38e5742
nit
dhrubabasu May 16, 2023
a4bca48
Merge branch 'dev' into ban-require-zero-len
dhrubabasu May 16, 2023
f824d68
Merge branch 'ban-require-zero-len' into ban-require-equal-len
dhrubabasu May 16, 2023
adf3e39
Merge branch 'ban-require-equal-len' into ban-require-nil
dhrubabasu May 16, 2023
b58df9d
merged
dhrubabasu May 16, 2023
b93c523
reduce diff
dhrubabasu May 16, 2023
3402670
merged
dhrubabasu May 17, 2023
51b303b
Merge branch 'dev' into enforce-require-no-error-inline
dhrubabasu May 18, 2023
dc4c374
merged
StephenButtolph May 26, 2023
115dfcb
Merge branch 'dev' into enforce-require-no-error-inline
StephenButtolph May 27, 2023
c2a7868
add comment that confused me
StephenButtolph May 30, 2023
66217b4
nit
StephenButtolph May 30, 2023
6c18e3e
Merge branch 'dev' into enforce-require-no-error-inline
StephenButtolph May 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix regex
  • Loading branch information
dhrubabasu committed May 12, 2023
commit 10dff9561e0d979502f08ed65c68cdb3d06e4852
2 changes: 1 addition & 1 deletion scripts/lint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ function test_require_equal_zero {
}

function test_require_len_zero {
if grep -R -o -P 'require\.Len\((t, )?.+?, 0,' .; then
if grep -R -o -P 'require\.Len\((t, )?.+?, 0(,|\))' .; then
echo ""
echo "Use require.Empty instead of require.Len when testing for 0 length."
echo ""
Expand Down