Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-1368]: Panic in serializedPath.HasPrefix #1371

Merged
merged 11 commits into from
Apr 20, 2023
Merged

[Issue-1368]: Panic in serializedPath.HasPrefix #1371

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
930dc8a
Update path.go
dboehm-avalabs Apr 17, 2023
d9a618c
Make It Harder To Construct Bad Serialized Paths
dboehm-avalabs Apr 17, 2023
b57f100
Update path.go
dboehm-avalabs Apr 17, 2023
1340ee6
Revert
dboehm-avalabs Apr 18, 2023
1c1bb82
Update syncmanager.go
dboehm-avalabs Apr 18, 2023
802a8f5
Update syncmanager.go
dboehm-avalabs Apr 18, 2023
9ad81c3
add tests
dboehm-avalabs Apr 18, 2023
45a32a5
Update path.go
dboehm-avalabs Apr 18, 2023
208c0b7
cleanup
dboehm-avalabs Apr 18, 2023
7732166
extra fix
dboehm-avalabs Apr 18, 2023
c458c6c
Merge branch 'dev' into Issue-1368
dboehm-avalabs Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update path.go
  • Loading branch information
@dboehm-avalabs
dboehm-avalabs committed Apr 18, 2023
commit 45a32a515752f59466f1d02cf8d598a3fbca17b9
7 changes: 6 additions & 1 deletion x/merkledb/path.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,14 @@ func (s SerializedPath) HasPrefix(prefix SerializedPath) bool {
return bytes.HasPrefix(s.Value, prefixValue)
}
reducedSize := len(prefixValue) - 1
if reducedSize < 0 {

// the input was invalid so just return false
if reducedSize < 0 ||
reducedSize >= len(prefixValue) ||
reducedSize >= len(s.Value) {
return false
}

// grab the last nibble in the prefix and serialized path
prefixRemainder := prefixValue[reducedSize] >> 4
valueRemainder := s.Value[reducedSize] >> 4
Expand Down