[Issue-1368]: Panic in serializedPath.HasPrefix #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
reviewed
Apr 17, 2023
darioush
approved these changes
Apr 18, 2023
danlaine
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check to ensure that invalid paths are just considered not prefixes rather than causing a panic. Change SerializedPaths to make it more difficult to construct invalid ones. An empty value and odd length is still an issue, but this prevents mismatched NibbleLength & Value size SerializedPaths from being constructed
I'm not sure that part two of issue 1368 is a bug. SerializedPath is just a wrapper around an array, so it behaves like an array when trying to access out of bounds indices.