Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avalanche-types): bump up rpcchainvm protocol version to 32 #157

Merged
merged 10 commits into from
Feb 27, 2024
Merged

feat(avalanche-types): bump up rpcchainvm protocol version to 32 #157

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5eb0386
feat(avalanche-types): bump up rpcchainvm protocol version to 33
gyuho Feb 22, 2024
5003f69
32
gyuho Feb 22, 2024
514a8dd
remove version
gyuho Feb 22, 2024
6604781
make it compile
gyuho Feb 22, 2024
44299c5
fix lint
gyuho Feb 22, 2024
b3dee76
more updates
gyuho Feb 26, 2024
a60be40
remove unused
gyuho Feb 26, 2024
760bff6
remove unused
gyuho Feb 26, 2024
08137b9
bump up to 33
gyuho Feb 27, 2024
b4e8913
comment out subnet feature
gyuho Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
32 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
  • Loading branch information
@gyuho
gyuho committed Feb 22, 2024
commit 5003f69e4220d34842d69ce870038ef1082b8c64
2 changes: 1 addition & 1 deletion crates/avalanche-types/scripts/protobuf_codegen.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# protocol version is the version of the gRPC proto definitions
# as defined by the avalanchego rpcchainvm.
# ref. https://github.com/ava-labs/avalanchego/blob/v1.11.0/version/constants.go
PROTOCOL_VERSION='33'
PROTOCOL_VERSION='32'

if ! [[ "$0" =~ scripts/protobuf_codegen.sh ]]; then
echo "must be run from repository root"
Expand Down
2 changes: 1 addition & 1 deletion crates/avalanche-types/src/proto/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ pub mod pb;
pub use pb::*;

/// ref. <https://github.com/ava-labs/avalanchego/blob/v1.11.0/version/constants.go>
pub const PROTOCOL_VERSION: u32 = 33;
pub const PROTOCOL_VERSION: u32 = 32;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there was no version 32?
https://github.com/ava-labs/avalanchego/blob/6dcd8e8adaeacb6d9e7f46654bfbd93639cbd22a/version/compatibility.json#L4

Loading