feat(avalanche-types): bump up rpcchainvm protocol version to 32 #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref. https://github.com/ava-labs/avalanchego/blob/v1.11.0/version/constants.go Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
richardpringle
approved these changes
Feb 26, 2024
crates/avalanche-types/Cargo.toml
Outdated
| @@ -121,7 +121,7 @@ default = [ | |||
| # "message", | |||
| # "mnemonic", | |||
| # "proto", | |||
| # "subnet", | |||
| "subnet", | |||
There was a problem hiding this comment.
Why make this a default feature? If it should be default, we can just remove the feature flag altogether.
(don't have to do this right now, I'm just curious)
| /// ref. <https://github.com/ava-labs/avalanchego/blob/v1.10.1/version/constants.go#L15-L17> | ||
| pub const PROTOCOL_VERSION: u32 = 28; | ||
| /// ref. <https://github.com/ava-labs/avalanchego/blob/v1.11.0/version/constants.go> | ||
| pub const PROTOCOL_VERSION: u32 = 32; |
There was a problem hiding this comment.
Looks like there was no version 32?
https://github.com/ava-labs/avalanchego/blob/6dcd8e8adaeacb6d9e7f46654bfbd93639cbd22a/version/compatibility.json#L4
| )) | ||
| })?; | ||
| let db = | ||
| corruptabledb::Database::new_boxed(DatabaseClient::new_boxed(db_client_conn.clone())); |
There was a problem hiding this comment.
Something tells me that there's more boxing than necessary here...
richardpringle
requested changes
Feb 26, 2024
There was a problem hiding this comment.
Sorry, trigger happy on the approval button.
Please address this comment:
#157 (comment)
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
richardpringle
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref. #155
From https://github.com/ava-labs/avalanchego/blob/v1.9.11/vms/rpcchainvm/vm_server.go
to https://github.com/ava-labs/avalanchego/blob/v1.11.1/vms/rpcchainvm/vm_server.go