Skip to content

feat(repos): re-introduce agnocast #6049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 22, 2025

Conversation

sykwer
Copy link
Member

@sykwer sykwer commented Apr 17, 2025

Description

Agnocast was previously reverted at #5986, but this pull request reintroduces it. The revert was originally done due to two issues:

  • Although agnocast-heaphook and agnocast-kmod were distributed via the PPA server conforming to semantic versioning, the PPA server has a specification that automatically disables the previous version upon a new release.
  • agnocast-kmod did not support certain Linux kernel versions (particularly 5.10).

These issues have now been resolved, so Agnocast is being reintroduced.

To address the limitation of the PPA, we separated the packages at the patch version level (major.minor.patch). For example, even if v2.1.1 is released, the release of v2.1.0 will no longer be discontinued, as they are now distinct packages (agnocast-kmod-v2.1.0, agnocast-kmod-v2.1.1, etc.).

How was this PR tested?

./setup-dev-env.sh
sudo modprobe agnocast
sudo modprobe -r agnocast
dkms status
dpkg -L agnocast-kmod
dpkg -L agnocast-heaphook

Notes for reviewers

None.

Effects on system behavior

None.

sykwer and others added 3 commits April 17, 2025 09:49
…tion#5917)

* add agnocast

Signed-off-by: sykwer <sykwer@gmail.com>

* style(pre-commit): autofix

Signed-off-by: sykwer <sykwer@gmail.com>

* fix

Signed-off-by: sykwer <sykwer@gmail.com>

* Update docker/Dockerfile

Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: sykwer <sykwer@gmail.com>

---------

Signed-off-by: sykwer <sykwer@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
…utowarefoundation#5930)

* install linux kernel header

Signed-off-by: sykwer <sykwer@gmail.com>

* fix

Signed-off-by: sykwer <sykwer@gmail.com>

---------

Signed-off-by: sykwer <sykwer@gmail.com>
Signed-off-by: sykwer <sykwer@gmail.com>
@sykwer sykwer self-assigned this Apr 17, 2025
Copy link

github-actions bot commented Apr 17, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@sykwer sykwer added the run:health-check Run health-check label Apr 17, 2025
sykwer added 2 commits April 17, 2025 11:21
Signed-off-by: sykwer <sykwer@gmail.com>
Signed-off-by: sykwer <sykwer@gmail.com>
@sykwer
Copy link
Member Author

sykwer commented Apr 19, 2025

Evaluator: TIER IV Internal Link
Build Succeeded.

@sykwer sykwer marked this pull request as ready for review April 19, 2025 18:00
@mitsudome-r
Copy link
Member

The change on this repo seems to be okay.
The CI is passing because we are not using agnocast at the moment. It might be safer if we also test it locally with packages that uses agnocast. @sykwer Have you tested the build with autoware_universe locally with this commit reverted?

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To build using arm64, I've updated the branch.
LGTM if health-check (main) and health-check (main-arm64) will be passed.

@sykwer
Copy link
Member Author

sykwer commented Apr 22, 2025

@mitsudome-r
Locally, the build succeeded with autowarefoundation/autoware_universe#10402 reverted.

@youtalk youtalk merged commit b0913be into autowarefoundation:main Apr 22, 2025
16 of 17 checks passed
@youtalk
Copy link
Member

youtalk commented Apr 22, 2025

Moving forward again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants