-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: path distance calculator #975
fix: path distance calculator #975
Conversation
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Codecov Report
@@ Coverage Diff @@
## main #975 +/- ##
========================================
- Coverage 9.56% 9.56% -0.01%
========================================
Files 941 941
Lines 58230 58233 +3
Branches 10577 10577
========================================
Hits 5572 5572
- Misses 47941 47944 +3
Partials 4717 4717
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
#281) * fix: path distance calculator (#975) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix(path_distance_calculator): do not calculate distance when too short path is subscribed (autowarefoundation#2892) * fix(path_distance_calculator): do not calculate distance when too short path is subscribed Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * unify conditions Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp
Description
When the size of path is 1, path distance calculator died with following messages.
I fixed it.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.