Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path distance calculator #975

Merged

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented May 26, 2022

Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp

Description

When the size of path is 1, path distance calculator died with following messages.

[path_distance_calculator_node-42] terminate called after throwing an instance of 'std::out_of_range'
[path_distance_calculator_node-42]   what():  vector::_M_range_check: __n (which is 1) >= this->size() (which is 1)

I fixed it.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #975 (060dabd) into main (3537ec1) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #975      +/-   ##
========================================
- Coverage   9.56%   9.56%   -0.01%     
========================================
  Files        941     941              
  Lines      58230   58233       +3     
  Branches   10577   10577              
========================================
  Hits        5572    5572              
- Misses     47941   47944       +3     
  Partials    4717    4717              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.56% <0.00%> (ø) Carriedforward from 3537ec1

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...stance_calculator/src/path_distance_calculator.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3537ec1...060dabd. Read the comment docs.

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit b284934 into autowarefoundation:main May 26, 2022
@tkimura4 tkimura4 deleted the fix/path_distance_calculator branch May 26, 2022 14:20
tkimura4 referenced this pull request in tier4/autoware.universe May 26, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Jun 7, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
h-ohta referenced this pull request in tier4/autoware.universe Feb 15, 2023
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
h-ohta referenced this pull request in tier4/autoware.universe Feb 27, 2023
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
h-ohta referenced this pull request in tier4/autoware.universe Feb 27, 2023
#281)

* fix: path distance calculator (#975)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix(path_distance_calculator): do not calculate distance when too short path is subscribed (autowarefoundation#2892)

* fix(path_distance_calculator): do not calculate distance when too short path is subscribed

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* unify conditions

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants