-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(path_distance_calculator): do not calculate distance when too short path is subscribed #2892
fix(path_distance_calculator): do not calculate distance when too short path is subscribed #2892
Conversation
…rt path is subscribed Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Codecov ReportBase: 11.62% // Head: 11.62% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2892 +/- ##
=======================================
Coverage 11.62% 11.62%
=======================================
Files 1321 1321
Lines 92140 92139 -1
Branches 24443 24443
=======================================
Hits 10714 10714
+ Misses 70244 70243 -1
Partials 11182 11182
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@isamu-takagi @yabuta |
common/path_distance_calculator/src/path_distance_calculator.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I leave it up to you to reflect the comments.
…rt path is subscribed (autowarefoundation#2892) * fix(path_distance_calculator): do not calculate distance when too short path is subscribed Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * unify conditions Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…rt path is subscribed (autowarefoundation#2892) * fix(path_distance_calculator): do not calculate distance when too short path is subscribed Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * unify conditions Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
#281) * fix: path distance calculator (#975) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix(path_distance_calculator): do not calculate distance when too short path is subscribed (autowarefoundation#2892) * fix(path_distance_calculator): do not calculate distance when too short path is subscribed Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * unify conditions Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
…rt path is subscribed (autowarefoundation#2892) * fix(path_distance_calculator): do not calculate distance when too short path is subscribed Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * unify conditions Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…rt path is subscribed (autowarefoundation#2892) * fix(path_distance_calculator): do not calculate distance when too short path is subscribed Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * unify conditions Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Description
Do not calculate distance when too short path is subscribed to avoid process-death by invalid access here
Related links
TERIV Internal
Tests performed
I confirmed that the path_distance_calculator node works normally using the planning simulator.
$ros2 launch path_distance_calculator path_distance_calculator.launch.xml
(But I didn't test that the node didn't die when a too short path is subscribed.)
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.