Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(universe_utils): reduce dependence on Boost.Geometry #8974

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

mitukou1109
Copy link
Contributor

@mitukou1109 mitukou1109 commented Sep 27, 2024

Description

This PR enables the following alternative geometry functions to support non-convex polygons.

Function Supported geometry types
area() ring / polygon
correct() polygon
covered_by() point & ring / point polygon
disjoint() polygon & polygon
distance() point & segment (2 edge points) / point & polygon
envelope() polygon
equals() point & point / polygon & polygon
intersects() segment & segment / polygon & polygon
touches() point & segment / point & polygon
within() point & ring / point & polygon / polygon & polygon

Note:

  • All functions above cannot be used for self-intersecting polygons. Some may work but possibly cause unintended behavior.

Related links

Parent Issue:

How was this PR tested?

colcon test --packages-select autoware_universe_utils

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Sep 27, 2024
Copy link

github-actions bot commented Sep 27, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitukou1109 mitukou1109 force-pushed the feat/no_boost_geometry_3 branch from b967eb4 to b48acc3 Compare October 1, 2024 08:44
@mitukou1109 mitukou1109 force-pushed the feat/no_boost_geometry_3 branch 3 times, most recently from eca891e to 577a87e Compare October 25, 2024 03:57
@mitukou1109
Copy link
Contributor Author

This PR should be merged after #8995. Currently the random tests fail because the concave polygon generator occasionally creates self-intersections.

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
@mitukou1109 mitukou1109 force-pushed the feat/no_boost_geometry_3 branch from 577a87e to 6f654f6 Compare October 28, 2024 00:49
Copy link

stale bot commented Dec 28, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant