Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interpolation): fix bug of interpolation #8903

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

yhisaki
Copy link
Contributor

@yhisaki yhisaki commented Sep 18, 2024

Description

Fixed a bug in the coefficient calculation of spline interpolation.

Related links

How was this PR tested?

https://evaluation.tier4.jp/evaluation/reports/1e862479-c0b9-5432-9b06-ca8817bb99f1?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@yhisaki yhisaki marked this pull request as ready for review September 18, 2024 06:27
@yhisaki yhisaki assigned yhisaki and takayuki5168 and unassigned yhisaki Sep 18, 2024
@yhisaki yhisaki added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 18, 2024
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 98.46154% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.99%. Comparing base (cd82008) to head (329ac4c).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
common/interpolation/src/spline_interpolation.cpp 98.46% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8903      +/-   ##
==========================================
- Coverage   27.99%   27.99%   -0.01%     
==========================================
  Files        1319     1319              
  Lines       98701    98713      +12     
  Branches    39785    39787       +2     
==========================================
+ Hits        27636    27638       +2     
- Misses      70991    71001      +10     
  Partials       74       74              
Flag Coverage Δ *Carryforward flag
differential 27.00% <98.46%> (?)
total 27.95% <ø> (-0.05%) ⬇️ Carriedforward from 8f292a6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki yhisaki enabled auto-merge (squash) September 19, 2024 04:51
@yhisaki yhisaki merged commit 7819089 into autowarefoundation:main Sep 19, 2024
26 checks passed
@yhisaki yhisaki deleted the fix-interpolation branch September 19, 2024 09:06
xmfcx pushed a commit to esteve/autoware.universe that referenced this pull request Sep 20, 2024
xmfcx pushed a commit to esteve/autoware.universe that referenced this pull request Sep 20, 2024
* fix(interpolation): fix bug of interpolation

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* add const

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* auto -> int64_t

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* add const

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* add const

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* add const

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

---------

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants