Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(custom_button): improve drop shadow effect #8781

Conversation

KhalilSelyan
Copy link
Contributor

@KhalilSelyan KhalilSelyan commented Sep 5, 2024

Description

Improve drop shadow effect by editing the blur radius and offset to be more center aligned

Related Links

Before

image

After

Selection_002

Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
@KhalilSelyan KhalilSelyan self-assigned this Sep 5, 2024
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 5, 2024
@xmfcx xmfcx enabled auto-merge (squash) September 5, 2024 15:24
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 24.97%. Comparing base (8213bdf) to head (14b5d03).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...mmon/tier4_state_rviz_plugin/src/custom_button.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8781      +/-   ##
==========================================
- Coverage   25.01%   24.97%   -0.04%     
==========================================
  Files        1322     1322              
  Lines       98044    98000      -44     
  Branches    37820    37788      -32     
==========================================
- Hits        24521    24473      -48     
- Misses      71044    71048       +4     
  Partials     2479     2479              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 24.97% <ø> (-0.04%) ⬇️ Carriedforward from 8213bdf

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xmfcx xmfcx merged commit eda5011 into autowarefoundation:main Sep 6, 2024
43 checks passed
emuemuJP pushed a commit to arayabrain/autoware.universe.origin that referenced this pull request Sep 10, 2024
…on#8781)

Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: emuemuJP <k.matsumoto.0807@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants