Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): add checks to ensure the edge of vehicle do not exceed target lane boundary when changing lanes #8750

Conversation

mkquda
Copy link
Contributor

@mkquda mkquda commented Sep 4, 2024

Description

Currently, LC path does not guarantee that ego vehicle is within target lane boundaries at all times during LC maneuver. Specifically for larger vehicles (such as bus or trucks), it is more likely that the vehicle frame exceeds the target lane boundary into the next lane during the maneuver, which can result in an unsafe interaction with other vehicles on the road.

This PR adds a safety check for LC candidate path to ensure ego footprint maintains a safe distance from the target lane far boundary for all path points.

If a candidate path does not satisfy the condition it will still be added as a valid path, but will not be considered a safe path.

Related links

autoware_launch PR

How was this PR tested?

PSIM.

Notes for reviewers

None.

Interface changes

ROS Parameter Changes

Additions and removals

Change type Parameter Name Type Default Value Description
Added enable_target_lane_bound_check bool true Flag to enable / disable target lane boundary check

Effects on system behavior

LC candidates path that result in ego foot print exceeding target lane far boundary will be considered unsafe.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 8.69565% with 21 lines in your changes missing coverage. Please review.

Project coverage is 27.98%. Comparing base (edb4179) to head (507a958).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
...havior_path_lane_change_module/src/utils/utils.cpp 0.00% 17 Missing ⚠️
...are_behavior_path_lane_change_module/src/scene.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8750      +/-   ##
==========================================
- Coverage   27.99%   27.98%   -0.02%     
==========================================
  Files        1319     1320       +1     
  Lines       98732    98784      +52     
  Branches    39797    39812      +15     
==========================================
+ Hits        27642    27646       +4     
- Misses      71047    71094      +47     
- Partials       43       44       +1     
Flag Coverage Δ *Carryforward flag
differential 15.56% <8.69%> (?)
total 27.99% <ø> (ø) Carriedforward from edb4179

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
@mkquda mkquda force-pushed the RT1-7610-add-checks-to-ensure-the-edge-of-vehicle-do-not-exceed-target-lane-boundary-when-changing-lanes branch from a031acd to 507a958 Compare September 18, 2024 23:08
@mkquda mkquda merged commit 3c7327a into autowarefoundation:main Sep 20, 2024
30 of 32 checks passed
@mkquda mkquda deleted the RT1-7610-add-checks-to-ensure-the-edge-of-vehicle-do-not-exceed-target-lane-boundary-when-changing-lanes branch September 20, 2024 08:29
batuhanbeytekin pushed a commit to batuhanbeytekin/autoware.universe that referenced this pull request Sep 20, 2024
…ceed target lane boundary when changing lanes (autowarefoundation#8750)

* check if LC candidate path footprint exceeds target lane far bound

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* add parameter to enable/disable check

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* check only lane changing section of cadidate path

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* fix spelling

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* small refactoring

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

---------

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants