-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): add checks to ensure the edge of vehicle do not exceed target lane boundary when changing lanes #8750
feat(lane_change): add checks to ensure the edge of vehicle do not exceed target lane boundary when changing lanes #8750
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8750 +/- ##
==========================================
- Coverage 27.99% 27.98% -0.02%
==========================================
Files 1319 1320 +1
Lines 98732 98784 +52
Branches 39797 39812 +15
==========================================
+ Hits 27642 27646 +4
- Misses 71047 71094 +47
- Partials 43 44 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/utils.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/utils.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/utils.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/utils.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/utils.cpp
Show resolved
Hide resolved
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
a031acd
to
507a958
Compare
…ceed target lane boundary when changing lanes (autowarefoundation#8750) * check if LC candidate path footprint exceeds target lane far bound Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> * add parameter to enable/disable check Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> * check only lane changing section of cadidate path Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> * fix spelling Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> * small refactoring Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> --------- Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
Description
Currently, LC path does not guarantee that ego vehicle is within target lane boundaries at all times during LC maneuver. Specifically for larger vehicles (such as bus or trucks), it is more likely that the vehicle frame exceeds the target lane boundary into the next lane during the maneuver, which can result in an unsafe interaction with other vehicles on the road.
This PR adds a safety check for LC candidate path to ensure ego footprint maintains a safe distance from the target lane far boundary for all path points.
If a candidate path does not satisfy the condition it will still be added as a valid path, but will not be considered a safe path.
Related links
autoware_launch PR
How was this PR tested?
PSIM.
Notes for reviewers
None.
Interface changes
ROS Parameter Changes
Additions and removals
enable_target_lane_bound_check
bool
true
Effects on system behavior
LC candidates path that result in ego foot print exceeding target lane far boundary will be considered unsafe.