fix(autoware_motion_utils): fix unusedFunction #8733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… points Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
kobayu858
requested review from
rej55,
kosuke55,
soblin,
satoshi-ota,
taikitanaka3,
TakaHoribe,
takayuki5168 and
tkimura4
as code owners
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kobayu858
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8733 +/- ##
=======================================
Coverage 25.04% 25.04%
=======================================
Files 1318 1318
Lines 97951 97961 +10
Branches 37813 37813
=======================================
+ Hits 24531 24539 +8
- Misses 70917 70921 +4
+ Partials 2503 2501 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tkimura4
approved these changes
Sep 5, 2024
emuemuJP
pushed a commit
to arayabrain/autoware.universe.origin
that referenced
this pull request
Sep 10, 2024
refactor:remove Path/Trajectory length calculation between designated points Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> Signed-off-by: emuemuJP <k.matsumoto.0807@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since
findFirstNearestSegmentIndexwas deleted in #8732 , it became necessary to make it consistent.Therefore, the section for calculating the length of the path/trajectory between specified points was deleted.
The
findFirstNearestSegmentIndexis not used in the actual code.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.