Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_obstacle_avoidance): change implementation the logic to remove invalid small shift lines #8721

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Sep 3, 2024

Description

Since this process generated invalid shift line whose relative longitudinal distance was ZERO, I added applySmallShiftFilter in #8344. But I think there is simpler way to fix the issue.

  for (size_t i = 0; i < sorted.size() - 1; ++i) {
    if (sorted.at(i + 1).start_longitudinal < sorted.at(i).end_longitudinal) {
      continue;
    }

    const auto new_line = fill(sorted.at(i), sorted.at(i + 1), generateUUID());
    ret.push_back(new_line);
    debug.step1_front_shift_line.push_back(new_line);
  }

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 3, 2024
@satoshi-ota satoshi-ota enabled auto-merge (squash) September 3, 2024 04:03
@satoshi-ota satoshi-ota merged commit 74bd8ed into autowarefoundation:main Sep 3, 2024
37 checks passed
@satoshi-ota satoshi-ota deleted the fix/not-use-small-shift-trim branch September 3, 2024 04:15
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 24.15%. Comparing base (58297a0) to head (7aff8be).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...acle_avoidance_module/src/shift_line_generator.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8721   +/-   ##
=======================================
  Coverage   24.15%   24.15%           
=======================================
  Files        1401     1402    +1     
  Lines      102286   102301   +15     
  Branches    38818    38818           
=======================================
+ Hits        24711    24715    +4     
- Misses      75097    75109   +12     
+ Partials     2478     2477    -1     
Flag Coverage Δ *Carryforward flag
differential 20.05% <0.00%> (?)
total 24.15% <ø> (+<0.01%) ⬆️ Carriedforward from 58297a0

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…move invalid small shift lines (autowarefoundation#8721)

* Revert "fix(static_obstacle_avoidance): remove invalid small shift lines (autowarefoundation#8344)"

This reverts commit 2705a63.

* fix(static_obstacle_avoidance): remove invalid small shift lines

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Dec 19, 2024
…move invalid small shift lines (autowarefoundation#8721)

* Revert "fix(static_obstacle_avoidance): remove invalid small shift lines (autowarefoundation#8344)"

This reverts commit 2705a63.

* fix(static_obstacle_avoidance): remove invalid small shift lines

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kotaro-hihara pushed a commit to tier4/autoware.universe that referenced this pull request Dec 23, 2024
… time (#1710)

* fix(static_obstacle_avoidance): change implementation the logic to remove invalid small shift lines (autowarefoundation#8721)

* Revert "fix(static_obstacle_avoidance): remove invalid small shift lines (autowarefoundation#8344)"

This reverts commit 2705a63.

* fix(static_obstacle_avoidance): remove invalid small shift lines

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(static_obstacle_avoidance): remove redundant calculation (autowarefoundation#8955)

remove redundant calculation

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>

* refactor(static_obstacle_avoidance): move route handler based calculation outside loop (autowarefoundation#8968)

* refactor filterTargetObjects

Signed-off-by: Go Sakayori <gsakayori@gmail.com>

* Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/src/utils.cpp

Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

---------

Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

* refactor(static obstacle avoidance): remove redundant calculation (autowarefoundation#9326)

* refactor bases on clang tidy

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>

* refactor extend backward length

Signed-off-by: Go Sakayori <gsakayori@gmail.com>

* mover redundant calculation in getRoadShoulderDistance

Signed-off-by: Go Sakayori <gsakayori@gmail.com>

---------

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
Signed-off-by: Go Sakayori <gsakayori@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com>
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Jan 17, 2025
…move invalid small shift lines (autowarefoundation#8721)

* Revert "fix(static_obstacle_avoidance): remove invalid small shift lines (autowarefoundation#8344)"

This reverts commit 2705a63.

* fix(static_obstacle_avoidance): remove invalid small shift lines

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Jan 18, 2025
…move invalid small shift lines (autowarefoundation#8721) (#1775)

Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
fix(static_obstacle_avoidance): remove invalid small shift lines (autowarefoundation#8344)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants