-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(static_obstacle_avoidance): change implementation the logic to remove invalid small shift lines #8721
fix(static_obstacle_avoidance): change implementation the logic to remove invalid small shift lines #8721
Conversation
…nes (autowarefoundation#8344)" This reverts commit 2705a63.
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8721 +/- ##
=======================================
Coverage 24.15% 24.15%
=======================================
Files 1401 1402 +1
Lines 102286 102301 +15
Branches 38818 38818
=======================================
+ Hits 24711 24715 +4
- Misses 75097 75109 +12
+ Partials 2478 2477 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…move invalid small shift lines (autowarefoundation#8721) * Revert "fix(static_obstacle_avoidance): remove invalid small shift lines (autowarefoundation#8344)" This reverts commit 2705a63. * fix(static_obstacle_avoidance): remove invalid small shift lines Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…move invalid small shift lines (autowarefoundation#8721) * Revert "fix(static_obstacle_avoidance): remove invalid small shift lines (autowarefoundation#8344)" This reverts commit 2705a63. * fix(static_obstacle_avoidance): remove invalid small shift lines Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
… time (#1710) * fix(static_obstacle_avoidance): change implementation the logic to remove invalid small shift lines (autowarefoundation#8721) * Revert "fix(static_obstacle_avoidance): remove invalid small shift lines (autowarefoundation#8344)" This reverts commit 2705a63. * fix(static_obstacle_avoidance): remove invalid small shift lines Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(static_obstacle_avoidance): remove redundant calculation (autowarefoundation#8955) remove redundant calculation Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> * refactor(static_obstacle_avoidance): move route handler based calculation outside loop (autowarefoundation#8968) * refactor filterTargetObjects Signed-off-by: Go Sakayori <gsakayori@gmail.com> * Update planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/src/utils.cpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> --------- Signed-off-by: Go Sakayori <gsakayori@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> * refactor(static obstacle avoidance): remove redundant calculation (autowarefoundation#9326) * refactor bases on clang tidy Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> * refactor extend backward length Signed-off-by: Go Sakayori <gsakayori@gmail.com> * mover redundant calculation in getRoadShoulderDistance Signed-off-by: Go Sakayori <gsakayori@gmail.com> --------- Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> Signed-off-by: Go Sakayori <gsakayori@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> Signed-off-by: Go Sakayori <gsakayori@gmail.com> Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com>
…move invalid small shift lines (autowarefoundation#8721) * Revert "fix(static_obstacle_avoidance): remove invalid small shift lines (autowarefoundation#8344)" This reverts commit 2705a63. * fix(static_obstacle_avoidance): remove invalid small shift lines Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…move invalid small shift lines (autowarefoundation#8721) (#1775) Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> fix(static_obstacle_avoidance): remove invalid small shift lines (autowarefoundation#8344)"
Description
Since this process generated invalid shift line whose relative longitudinal distance was ZERO, I added applySmallShiftFilter in #8344. But I think there is simpler way to fix the issue.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.