Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(autoware_behavior_path_planner_common): add tests for calcInterpolatedPoseWithVelocity #8270

Merge branch 'main' into test/autoware_behavior_path_planner_common

5a17ee9
Select commit
Loading
Failed to load commit list.
Merged

test(autoware_behavior_path_planner_common): add tests for calcInterpolatedPoseWithVelocity #8270

Merge branch 'main' into test/autoware_behavior_path_planner_common
5a17ee9
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Sep 6, 2024 in 25s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -1.38 (9.56 -> 8.18)

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Assertion Blocks test_safety_check.cpp
  • Excess Number of Function Arguments test_safety_check.cpp: createPose

Annotations

Check warning on line 49 in planning/behavior_path_planner/autoware_behavior_path_planner_common/test/test_safety_check.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

createPose has 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 243 in planning/behavior_path_planner/autoware_behavior_path_planner_common/test/test_safety_check.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Assertion Blocks

The test suite contains 7 assertion blocks with at least 4 assertions, threshold = 4. This test file has several blocks of large, consecutive assert statements. Avoid adding more.