Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(autoware_behavior_path_planner_common): add tests for calcInterpolatedPoseWithVelocity #8270

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Jul 30, 2024

Description

Add test for calcInterpolatedPoseWithVelocity in the autoware_behavior_path_planner_common package

Coverage is improved a bit.
image

How was this PR tested?

conductin colcon test in local environment

colcon test --event-handlers console_cohesion+ --packages-select autoware_behavior_path_planner_common

get following result

2: [----------] 3 tests from CalcInterpolatedPoseWithVelocityTest
2: [ RUN      ] CalcInterpolatedPoseWithVelocityTest.BasicInterpolation
2: [       OK ] CalcInterpolatedPoseWithVelocityTest.BasicInterpolation (0 ms)
2: [ RUN      ] CalcInterpolatedPoseWithVelocityTest.BoundaryConditions
2: [       OK ] CalcInterpolatedPoseWithVelocityTest.BoundaryConditions (0 ms)
2: [ RUN      ] CalcInterpolatedPoseWithVelocityTest.InvalidInput
2: [       OK ] CalcInterpolatedPoseWithVelocityTest.InvalidInput (0 ms)
2: [----------] 3 tests from CalcInterpolatedPoseWithVelocityTest (0 ms total)

Notes for reviewers

The tests defined in DISABLED_SpecialCases are temporarily disabled because same_time_result should return nullopt for interpolation of consecutive points at the same time. The implementation will be modified in different PR.

Effects on system behavior

None.

Copy link

github-actions bot commented Jul 30, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kyoichi-sugahara kyoichi-sugahara added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.95%. Comparing base (301e36b) to head (5a17ee9).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8270      +/-   ##
==========================================
- Coverage   25.02%   24.95%   -0.08%     
==========================================
  Files        1322     1331       +9     
  Lines       98047    98355     +308     
  Branches    37795    37819      +24     
==========================================
+ Hits        24536    24542       +6     
- Misses      71020    71322     +302     
  Partials     2491     2491              
Flag Coverage Δ *Carryforward flag
differential 14.94% <ø> (?)
total 25.04% <ø> (+0.02%) ⬆️ Carriedforward from 301e36b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit 78e4a92 into autowarefoundation:main Sep 6, 2024
35 of 42 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the test/autoware_behavior_path_planner_common branch September 6, 2024 08:00
emuemuJP pushed a commit to arayabrain/autoware.universe.origin that referenced this pull request Sep 10, 2024
…olatedPoseWithVelocity (autowarefoundation#8270)

* test: add interpolated pose calculation function's test

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* disabled SpecialCases test

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: emuemuJP <k.matsumoto.0807@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants