Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(autoware_auto_perception_rviz_plugin): add simple_visualization_mode for predicted path #6799

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iwatake2222
Copy link
Contributor

@iwatake2222 iwatake2222 commented Apr 12, 2024

Description

  • Background
    • FPS on rviz decreases from 30 fps to 5~15 fps when many objects appears due to drawing predicted paths
    • Existing "Simple" mode improves the FPS, but it still less than 30 fps in some cases so more improvement is needed
  • Changes
    • This PR adds "Simple2" mode to lighten the rendering process

Tests performed

Appearance

  • Normal
    • image
  • Simple <- existing
    • image
  • Simple2 <- New!!
    • image

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: takeshi.iwanari <take.iwiw2222@gmail.com>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Apr 12, 2024
@iwatake2222 iwatake2222 changed the title chore(common): add simple_visualization_mode for rviz perf(autoware_auto_perception_rviz_plugin): add simple_visualization_mode for predicted path Apr 12, 2024
@Owen-Liuyuxuan
Copy link
Contributor

Owen-Liuyuxuan commented May 8, 2024

@tkimura4

I would like to ask why we are using line list instead of line strip for path visualization.

line list takes two times more points in the message to show the same path line.

The most efficient idea should be

  1. Use Line strip for lines.
  2. Use sphere list to render all node points on the path (use one single sphere list for all paths to speed up the rendering)

Copy link

stale bot commented Jul 7, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants