refactor(behavior_velocity): occlusion spot #601

taikitanaka3 · 2022-03-29T03:28:02Z

Description

#258
refactor occlusion spot

make sure behavior is the same as before

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

codecov · 2022-03-29T03:54:15Z

Codecov Report

Merging #601 (60a17c9) into main (21a3037) will decrease coverage by 5.03%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             main    #601      +/-   ##
=========================================
- Coverage   10.85%   5.81%   -5.04%     
=========================================
  Files         708      68     -640     
  Lines       50173    5053   -45120     
  Branches     6579     545    -6034     
=========================================
- Hits         5445     294    -5151     
+ Misses      40321    4596   -35725     
+ Partials     4407     163    -4244

Impacted Files	Coverage Δ
...ene_module/occlusion_spot/occlusion_spot_utils.hpp	`25.00% <ø> (ø)`
..._planner/src/scene_module/occlusion_spot/debug.cpp	`0.00% <0.00%> (ø)`
...ene_module/occlusion_spot/occlusion_spot_utils.cpp	`9.67% <0.00%> (+0.05%)`	⬆️
..._module/occlusion_spot/risk_predictive_braking.cpp	`52.00% <ø> (+2.94%)`	⬆️
...ene_module/occlusion_spot/scene_occlusion_spot.cpp	`0.00% <0.00%> (ø)`
...c/lanelet2_map_loader/lanelet2_map_loader_node.cpp
...l/trajectory_follower/test/test_lowpass_filter.cpp
...bject_tracker/tracker/model/pedestrian_tracker.hpp
control/trajectory_follower/test/test_pid.cpp
common/motion_testing/test/constant_trajectory.cpp
... and 636 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21a3037...60a17c9. Read the comment docs.

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

0x126

LGTM

* refactor(behavior_velocity): refactor codes Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * refactor(behavior_velocity): fix typo Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * refactor(behavior_velocity): refactor debuggings Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * refactor(behavior_velocity): unite to generate Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * refactor(behavior_velocity): apply clang tidy Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(behavior_velocity): retun to default settting Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

…n#4034) (autowarefoundation#601) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore: add reviewer/assignee of sync-awf-latest-reference-design's PR (autowarefoundation#594) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * ci(slack-send): remove unused workflow (autowarefoundation#600) Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * ci(sync-files): sync .fdignore and .rgignore (autowarefoundation#601) * chore: sync files (autowarefoundation#588) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * feat: rename launch branch (autowarefoundation#604) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: remove sync-awf-latest-<reference-desing>.yaml (autowarefoundation#608) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * chore: sync files (autowarefoundation#602) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: tier4-autoware-private-bot[bot] <87871706+tier4-autoware-private-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* chore: add reviewer/assignee of sync-awf-latest-reference-design's PR (autowarefoundation#594) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * ci(slack-send): remove unused workflow (autowarefoundation#600) Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * ci(sync-files): sync .fdignore and .rgignore (autowarefoundation#601) * chore: sync files (autowarefoundation#588) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * feat: rename launch branch (autowarefoundation#604) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: remove sync-awf-latest-<reference-desing>.yaml (autowarefoundation#608) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * chore: sync files (autowarefoundation#602) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * chore(deps): replace peter-evans/enable-pull-request-automerge with GitHub CLI (autowarefoundation#612) * build(deps): bump peter-evans/enable-pull-request-automerge from 2 to 3 Bumps [peter-evans/enable-pull-request-automerge](https://github.com/peter-evans/enable-pull-request-automerge) from 2 to 3. - [Release notes](https://github.com/peter-evans/enable-pull-request-automerge/releases) - [Commits](peter-evans/enable-pull-request-automerge@v2...v3) --- updated-dependencies: - dependency-name: peter-evans/enable-pull-request-automerge dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Update update-beta-branch.yaml --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * chore: sync files (autowarefoundation#609) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * chore(deps): bump peter-evans/create-pull-request from 4 to 5 (autowarefoundation#613) Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 4 to 5. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v4...v5) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: use GitHub instead of Github (autowarefoundation#616) doc: use GitHub instead of Github --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: GitHub <noreply@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: tier4-autoware-private-bot[bot] <87871706+tier4-autoware-private-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

…foundation#601) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

chore: sync awf-latest

taikitanaka3 added 5 commits March 28, 2022 14:10

refactor(behavior_velocity): refactor codes

c4ee2eb

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

refactor(behavior_velocity): fix typo

fa71d7e

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

refactor(behavior_velocity): refactor debuggings

b985d0d

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

refactor(behavior_velocity): unite to generate

59e3180

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

refactor(behavior_velocity): apply clang tidy

0ecb73c

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

taikitanaka3 requested a review from 0x126 March 29, 2022 03:28

taikitanaka3 changed the title ~~Refactor behavior velocity occlusion spot~~ refactor(behavior_velocity): occlusion spot Mar 29, 2022

taikitanaka3 marked this pull request as ready for review March 29, 2022 04:15

taikitanaka3 requested a review from yukkysaito March 29, 2022 04:15

chore(behavior_velocity): retun to default settting

60a17c9

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

0x126 approved these changes Mar 29, 2022

View reviewed changes

yukkysaito approved these changes Mar 29, 2022

View reviewed changes

taikitanaka3 merged commit ca59048 into autowarefoundation:main Mar 29, 2022

tier4-autoware-public-bot bot mentioned this pull request Mar 30, 2022

chore: sync upstream tier4/autoware.universe#29

Merged

taikitanaka3 deleted the refactor-behavior-velocity-occlusion-spot branch March 30, 2022 05:14

badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Jun 26, 2023

feat(avoidance): ignore behind unavoidable objects (autowarefoundatio…

24b2706

…n#4034) (autowarefoundation#601) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023

ci(sync-files): sync .fdignore and .rgignore (#601)

5eabb75

iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025

feat(lane_change): expand target lanes for object filtering (autoware…

da1cfda

…foundation#601) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware.universe that referenced this pull request Feb 6, 2025

Merge pull request autowarefoundation#601 from tier4/sync-awf-latest

afbcb77

chore: sync awf-latest

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(behavior_velocity): occlusion spot #601

refactor(behavior_velocity): occlusion spot #601

taikitanaka3 commented Mar 29, 2022 •

edited

Loading

codecov bot commented Mar 29, 2022 •

edited

Loading

0x126 left a comment

refactor(behavior_velocity): occlusion spot #601

refactor(behavior_velocity): occlusion spot #601

Conversation

taikitanaka3 commented Mar 29, 2022 • edited Loading

Description

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Mar 29, 2022 • edited Loading

Codecov Report

0x126 left a comment

Choose a reason for hiding this comment

taikitanaka3 commented Mar 29, 2022 •

edited

Loading

codecov bot commented Mar 29, 2022 •

edited

Loading