Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity): occlusion spot merge scene modules #528

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Mar 16, 2022

Related Issue(required)

#258

Description(required)

This PR is going to change

pass_judge option is going to be enable for velocity smoother PR #497 currently "smooth_velocity" is not available

      detection_method: "occupancy_grid" # [-] candidate is "occupancy_grid" or "predicted_object"
      pass_judge: "current_velocity"       # [-] candidate is "current_velocity" or "smooth_velocity"

This PR is NOT going to change

  • adding new features or adding new files
  • parameter change

Review Procedure(required)

  • make sure behavior is the same as before. below option should be tested
      detection_method: "occupancy_grid" # [-] candidate is "occupancy_grid" or "predicted_object"
  • test in experiment at kashiwanoha

with #497

occlusion-2022-03-16_11.49.23.mp4
occlusion-2022-03-16_11.58.45.mp4

Related PR(optional)

#497

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
…tion as util

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #528 (603cb9c) into main (fa2bca8) will decrease coverage by 5.13%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             main    #528      +/-   ##
=========================================
- Coverage   10.97%   5.83%   -5.14%     
=========================================
  Files         705      68     -637     
  Lines       49781    4954   -44827     
  Branches     7119     683    -6436     
=========================================
- Hits         5462     289    -5173     
+ Misses      39933    4527   -35406     
+ Partials     4386     138    -4248     
Impacted Files Coverage Δ
...er/include/scene_module/occlusion_spot/manager.hpp 0.00% <ø> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.hpp 40.00% <0.00%> (ø)
...vior_velocity_planner/include/utilization/util.hpp 5.88% <0.00%> (-2.12%) ⬇️
..._planner/src/scene_module/occlusion_spot/debug.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/occlusion_spot/grid_utils.cpp 23.71% <0.00%> (ø)
...lanner/src/scene_module/occlusion_spot/manager.cpp 0.00% <0.00%> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.cpp 9.72% <0.00%> (-0.50%) ⬇️
..._module/occlusion_spot/risk_predictive_braking.cpp 48.38% <ø> (-2.32%) ⬇️
...ene_module/occlusion_spot/scene_occlusion_spot.cpp 0.00% <0.00%> (ø)
...behavior_velocity_planner/src/utilization/util.cpp 27.23% <0.00%> (-9.97%) ⬇️
... and 639 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa2bca8...603cb9c. Read the comment docs.

@yukkysaito
Copy link
Contributor

@taikitanaka3 Is the detection area supposed to use smoother results?

@taikitanaka3
Copy link
Contributor Author

taikitanaka3 commented Mar 16, 2022

@yukkysaito
create detection area polygon only converts velocity in path so it can convert any path point velocity such as

  • current velocity into path(only consider v0)
  • velocity of constant acceleration in path( v0 + a0 * t or whatever)
    in this PR current velocity is applied to path to make detection area.

However with PR #497

  • velocity of smoothed path consider external velocity limit
    is available as an option.

@yukkysaito
Copy link
Contributor

yukkysaito commented Mar 16, 2022

velocity is applied to path to make detection area.

@taikitanaka3
In this PR, are you using the maximum velocity that is in the path and v0,a0?

@taikitanaka3
Copy link
Contributor Author

@yukkysaito
in this PR there is no function change as described in PR so current velcity is only available

  • current velocity into path(only consider v0)

yukkysaito
yukkysaito previously approved these changes Mar 16, 2022
pull bot pushed a commit to kenji-miyake/autoware.universe that referenced this pull request Mar 16, 2022
* release v0.4.0

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit 6ab6bcca1dea5065fcb06aeec107538dad1f62af.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Rename launch files to launch.xml (#28)

* ROS2 Porting: dummy_diag_publisher (#69)

* Fix CMake, package.xml and remove COLCON_IGNORE

* First pass
 - Remove ROS references: dynamic_configuration
 - Can compile

* Fix references to dynamic_reconfigure
 - Clean up comments in cmake and package.xml
 - Add timer callback

* Modify config yamls and remove dynamic reconfigure file
 - Fix launch files

* Fix declaration of parameters using get parameters
 - Add rqt_reconfigure to package deps

* Add comment in launch file

* Remove fmt dependency

* Address PR comment:

- Ensure that status value is initialised properly

Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>

* Address PR comment:

- Ensure config are declared to ensure it can be set in the parameter callback

Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>

* Address PR comment:
 - Remove headers from executable generation in cmake

* Address PR comment:
 - Remove headers specification

Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>

* Rename h files to hpp (#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (#143)

* Use quotes for includes where appropriate (#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Run uncrustify on the entire Pilot.Auto codebase (#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* Add linters (#208)

* Rename ROS-related .yaml to .param.yaml (#352)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove prefix 'default_' of yaml files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename diagnostic_aggregator's param files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix overlooked parameters

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add use_sim-time option (autowarefoundation#454)

* Fix for rolling (autowarefoundation#1226)

* Replace doc by description

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Replace ns by push-ros-namespace

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Cleanup dummy_diag_publisher (autowarefoundation#1392)

* Cleanup dummy_diag_publisher

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typo

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Make double and write comment

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Set hardware_id from diag_name

* Add const to daig_name and hardware_id

Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>

* suppress warnings for declare parameters (autowarefoundation#1724)

* fix for lanelet2_extension

* fix for traffic light ssd fine detector

* fix for topic_state_monitor

* fix for dummy diag publisher

* fix for remote cmd converter

* fix for vehicle_info_util

* fix for multi object tracker

* fix for freespace planner

* fix for autoware_error_monitor

* add Werror for multi object tracker

* fix for multi object tracker

* add Werror for liraffic light ssd fine detector

* add Werror for topic state monitor

* add Werror

* add Werror

* add Werror

* add Werror

* fix style

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* Fix typo `obstacle_crush` to `obstacle_crash` (autowarefoundation#2031)

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* Refactor dummy_diag_publisher (autowarefoundation#2151)

* Refactor dummy_diag_publisher

* fix depend order

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* remove COLCON_IGNORE in dummy_diag_publisher (autowarefoundation#528)

* add README in dummy diag publisher (autowarefoundation#627)

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3
Copy link
Contributor Author

image
make sure behavior is same as before(current velocity = rectangle polygon)

@taikitanaka3 taikitanaka3 requested a review from yukkysaito March 18, 2022 03:24
@taikitanaka3 taikitanaka3 enabled auto-merge (squash) March 18, 2022 03:24
@taikitanaka3
Copy link
Contributor Author

  • release note

@taikitanaka3 taikitanaka3 merged commit 3693cbb into autowarefoundation:main Mar 18, 2022
@taikitanaka3 taikitanaka3 deleted the 258-refactor-occlusion-spot-merge-scene-modules branch March 23, 2022 03:48
taikitanaka3 added a commit to taikitanaka3/autoware.universe that referenced this pull request Mar 23, 2022
…warefoundation#528)

* refactor(behavior_velocity): refactor slice to general type

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): Basic Polygon to general polygon2d

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): generalize da polygon usage

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): remove replaced function

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite create detection area polygon function as util

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor method

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): add pass judge param

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): move judgement

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): replace with tier4 autoware utils

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): fix spell check

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): merge occlusion spot sepated module

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): handle boundary condition for better

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
taikitanaka3 referenced this pull request in tier4/autoware.universe Apr 9, 2022
* refactor(behavior_velocity): refactor slice to general type

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): Basic Polygon to general polygon2d

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): generalize da polygon usage

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): remove replaced function

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite create detection area polygon function as util

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor method

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): add pass judge param

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): move judgement

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): replace with tier4 autoware utils

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): fix spell check

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): merge occlusion spot sepated module

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): handle boundary condition for better

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
taikitanaka3 referenced this pull request in tier4/autoware.universe Apr 14, 2022
* refactor(behavior_velocity): refactor slice to general type

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): Basic Polygon to general polygon2d

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): generalize da polygon usage

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): remove replaced function

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite create detection area polygon function as util

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor method

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): add pass judge param

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): move judgement

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): replace with tier4 autoware utils

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): fix spell check

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): merge occlusion spot sepated module

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): handle boundary condition for better

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
taikitanaka3 referenced this pull request in tier4/autoware.universe Apr 14, 2022
* refactor(behavior_velocity): refactor slice to general type

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): Basic Polygon to general polygon2d

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): generalize da polygon usage

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): remove replaced function

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite create detection area polygon function as util

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor method

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): add pass judge param

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): move judgement

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): replace with tier4 autoware utils

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): fix spell check

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): merge occlusion spot sepated module

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): handle boundary condition for better

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request May 16, 2022
…warefoundation#528)

* refactor(behavior_velocity): refactor slice to general type

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): Basic Polygon to general polygon2d

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): generalize da polygon usage

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): remove replaced function

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite create detection area polygon function as util

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor method

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): add pass judge param

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): move judgement

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): replace with tier4 autoware utils

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): fix spell check

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): merge occlusion spot sepated module

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): handle boundary condition for better

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…4#528)

* refactor(behavior_velocity): refactor slice to general type

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): Basic Polygon to general polygon2d

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): generalize da polygon usage

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): remove replaced function

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite create detection area polygon function as util

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor method

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): add pass judge param

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): move judgement

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): replace with tier4 autoware utils

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): fix spell check

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): merge occlusion spot sepated module

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): handle boundary condition for better

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…4#528)

* refactor(behavior_velocity): refactor slice to general type

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): Basic Polygon to general polygon2d

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): generalize da polygon usage

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): remove replaced function

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite create detection area polygon function as util

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor method

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): add pass judge param

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): move judgement

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): replace with tier4 autoware utils

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): fix spell check

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): merge occlusion spot sepated module

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): handle boundary condition for better

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…4#528)

* refactor(behavior_velocity): refactor slice to general type

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): Basic Polygon to general polygon2d

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): generalize da polygon usage

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): remove replaced function

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite create detection area polygon function as util

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor method

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): add pass judge param

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): move judgement

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): replace with tier4 autoware utils

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): fix spell check

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): merge occlusion spot sepated module

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): handle boundary condition for better

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
Signed-off-by: GitHub <noreply@github.com>

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
YamatoAndo pushed a commit to YamatoAndo/autoware.universe that referenced this pull request Aug 8, 2024
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants