Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): fix previous data inconsistency #4269

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 13, 2023

Description

Close #4178

If it fails to generate avoidance path, module doesn't update any previous data.

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota marked this pull request as ready for review July 13, 2023 02:44
@satoshi-ota satoshi-ota self-assigned this Jul 13, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (4d9d98f) 14.20% compared to head (752f401) 14.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4269      +/-   ##
==========================================
- Coverage   14.20%   14.20%   -0.01%     
==========================================
  Files        1597     1597              
  Lines      109902   109903       +1     
  Branches    31526    31524       -2     
==========================================
- Hits        15613    15611       -2     
- Misses      77338    77342       +4     
+ Partials    16951    16950       -1     
Flag Coverage Δ *Carryforward flag
differential 13.62% <0.00%> (?)
total 14.21% <ø> (+<0.01%) ⬆️ Carriedforward from 4d9d98f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 11.54% <0.00%> (-0.13%) ⬇️
...th_planner/src/scene_module/lane_change/normal.cpp 5.18% <0.00%> (-0.45%) ⬇️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.37% <ø> (+0.02%) ⬆️
...ing/behavior_velocity_run_out_module/src/debug.cpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota
Copy link
Contributor Author

@rej55 I would like you to review and approve as code owner if you're available. @ismetatabay san has already confirmed that this PR resolves #4178.

@satoshi-ota satoshi-ota merged commit cb37d94 into autowarefoundation:main Jul 13, 2023
@satoshi-ota satoshi-ota deleted the fix/previous-data-inconsistency branch July 13, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoidance module dies in U turns with spesific conditions
2 participants