-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(accel_brake_map_calibrator): fix parameter file #410
Merged
tkimura4
merged 1 commit into
autowarefoundation:tier4/proposal
from
tkimura4:fix/accel_brake_map_calibrator_param_file
Feb 18, 2022
Merged
fix(accel_brake_map_calibrator): fix parameter file #410
tkimura4
merged 1 commit into
autowarefoundation:tier4/proposal
from
tkimura4:fix/accel_brake_map_calibrator_param_file
Feb 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
taikitanaka3
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tkimura4
referenced
this pull request
in tier4/autoware.universe
Feb 21, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
mitsudome-r
added a commit
to mitsudome-r/autoware.universe
that referenced
this pull request
Mar 1, 2022
* Ros2 v0.8.0 topic state monitor (autowarefoundation#283) * Add node_name_suffix to topic_state_monitor.launch (autowarefoundation#1157) (autowarefoundation#370) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix launch file (autowarefoundation#411) * add transient local option to topic state monitor (autowarefoundation#410) * add transient local option to topic state monitor * sort parameters * sort parameter * [topic_state_monitor]: Add best effort option (autowarefoundation#430) Signed-off-by: autoware <autoware@example.com> Co-authored-by: autoware <autoware@example.com> * add use_sim-time option (autowarefoundation#454) * Fix for rolling (autowarefoundation#1226) * Replace doc by description Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Replace ns by push-ros-namespace Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * change to composable node (autowarefoundation#1233) * Unify Apache-2.0 license name (autowarefoundation#1242) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix lint errors (autowarefoundation#1378) * Fix lint errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix variable names Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Use integrated generic subscription (autowarefoundation#1342) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * suppress warnings for declare parameters (autowarefoundation#1724) * fix for lanelet2_extension * fix for traffic light ssd fine detector * fix for topic_state_monitor * fix for dummy diag publisher * fix for remote cmd converter * fix for vehicle_info_util * fix for multi object tracker * fix for freespace planner * fix for autoware_error_monitor * add Werror for multi object tracker * fix for multi object tracker * add Werror for liraffic light ssd fine detector * add Werror for topic state monitor * add Werror * add Werror * add Werror * add Werror * fix style * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * remove COLCON_IGNORE in system_packages and map_tf_generator (autowarefoundation#532) * [topic_state_monitor]add readme (autowarefoundation#565) * add readme * Update system/topic_state_monitor/Readme.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Update system/topic_state_monitor/Readme.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Update system/topic_state_monitor/Readme.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Update system/topic_state_monitor/Readme.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Update system/topic_state_monitor/Readme.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: autoware <autoware@example.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
May 20, 2022
…on#410) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
May 31, 2022
…on#410) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
TomohitoAndo
pushed a commit
to TomohitoAndo/autoware.universe
that referenced
this pull request
Oct 5, 2022
…velop sync main for develop
TomohitoAndo
pushed a commit
to TomohitoAndo/autoware.universe
that referenced
this pull request
Oct 5, 2022
chore: sync awf-latest
keiota
pushed a commit
to keiota/autoware.universe
that referenced
this pull request
Aug 17, 2023
…utowarefoundation#410) Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
keiota
pushed a commit
to keiota/autoware.universe
that referenced
this pull request
Aug 17, 2023
…ta_time" (autowarefoundation#415) Revert "feat(behavior_path_planner): relax longitudinal_velocity_delta_time (autowarefoundation#410)" This reverts commit e100e56.
kyoichi-sugahara
pushed a commit
that referenced
this pull request
Sep 16, 2023
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
YamatoAndo
pushed a commit
to YamatoAndo/autoware.universe
that referenced
this pull request
Aug 8, 2024
* Create COLCON_IGNORE * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp
Related Issue(required)
Description(required)
Fix the parameter file of accel_brake_map_calibrator
Review Procedure(required)
$ros2 launch accel_brake_map_calibrator accel_brake_map_calibrator.launch.xml
$ros2 param dump --print /accel_brake_map_calibrator
Confirm that the parameters match the parameter file.
Related PR(optional)
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
If you are adding new package following items are required:
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks