Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option to use validator node in detection module #1233

Merged
merged 5 commits into from
Jul 5, 2022
Merged

feat: add option to use validator node in detection module #1233

merged 5 commits into from
Jul 5, 2022

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Jul 5, 2022 •
edited
Loading

Description

Add option to use validator node in detection module

Review Procedure

$ ros2 launch tier4_perception_launch perception.launch.xml mode:=lidar/camera_lidar_fusion use_validator:=true/false

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@tkimura4
feat: add option to use validator node in detection module
b993942 
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4
fix
5a7bf88 
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested a review from yukkysaito July 5, 2022 05:47
@tkimura4 tkimura4 changed the title Feature/add option to use validator feat: add option to use validator node in detection module Jul 5, 2022
@tkimura4
remove use_validator option in detection/perception.launch
f8edc5e 
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@codecov
Copy link

codecov bot commented Jul 5, 2022 •
edited
Loading

Codecov Report

Merging #1233 (fb3fac0) into main (63f45ff) will not change coverage.
The diff coverage is n/a.

❗ Current head fb3fac0 differs from pull request most recent head ee4663a. Consider uploading reports for the commit ee4663a to get more accurate results

@@          Coverage Diff          @@
##            main   #1233   +/-   ##
=====================================
  Coverage   9.52%   9.52%           
=====================================
  Files       1051    1051           
  Lines      72465   72465           
  Branches   15776   15776           
=====================================
  Hits        6905    6905           
  Misses     59280   59280           
  Partials    6280    6280
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 9.51% <ø> (ø) Carriedforward from f8edc5e

*This pull request uses carry forward flags. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63f45ff...ee4663a. Read the comment docs.

@tkimura4
fix
fb3fac0 
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 mentioned this pull request Jul 5, 2022
Merged
8 tasks
@tkimura4 tkimura4 enabled auto-merge (squash) July 5, 2022 06:16
@tkimura4
apply pre-commit
ee4663a 
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 merged commit 6247671 into autowarefoundation:main Jul 5, 2022
@tkimura4 tkimura4 deleted the feature/add_option_to_use_validator branch July 5, 2022 16:39
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 6, 2022
Merged
miursh pushed a commit to miursh/autoware.universe that referenced this pull request Jul 12, 2022
@tkimura4 @wep21
@mitsudome-r @kenji-miyake @kmiya @h-ohta @1222-takeshi @taikitanaka3
feat: add topic_state_monitor package (autowarefoundation#15)
6dd12d6 
* Ros2 v0.8.0 topic state monitor (autowarefoundation#283)

* Add node_name_suffix to topic_state_monitor.launch (autowarefoundation#1157) (autowarefoundation#370)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix launch file (autowarefoundation#411)

* add transient local option to topic state monitor (autowarefoundation#410)

* add transient local option to topic state monitor

* sort parameters

* sort parameter

* [topic_state_monitor]: Add best effort option (autowarefoundation#430)

Signed-off-by: autoware <autoware@example.com>

Co-authored-by: autoware <autoware@example.com>

* add use_sim-time option (autowarefoundation#454)

* Fix for rolling (autowarefoundation#1226)

* Replace doc by description

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Replace ns by push-ros-namespace

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* change to composable node (autowarefoundation#1233)

* Unify Apache-2.0 license name (autowarefoundation#1242)

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix lint errors (autowarefoundation#1378)

* Fix lint errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix variable names

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use integrated generic subscription (autowarefoundation#1342)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* suppress warnings for declare parameters (autowarefoundation#1724)

* fix for lanelet2_extension

* fix for traffic light ssd fine detector

* fix for topic_state_monitor

* fix for dummy diag publisher

* fix for remote cmd converter

* fix for vehicle_info_util

* fix for multi object tracker

* fix for freespace planner

* fix for autoware_error_monitor

* add Werror for multi object tracker

* fix for multi object tracker

* add Werror for liraffic light ssd fine detector

* add Werror for topic state monitor

* add Werror

* add Werror

* add Werror

* add Werror

* fix style

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* remove COLCON_IGNORE in system_packages and map_tf_generator (autowarefoundation#532)

* [topic_state_monitor]add readme (autowarefoundation#565)

* add readme

* Update system/topic_state_monitor/Readme.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Update system/topic_state_monitor/Readme.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Update system/topic_state_monitor/Readme.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Update system/topic_state_monitor/Readme.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Update system/topic_state_monitor/Readme.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: autoware <autoware@example.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@tkimura4 @boyali
feat: add option to use validator node in detection module (tier4#1233)
c95aa7b 
* feat: add option to use validator node in detection module

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* remove use_validator option in detection/perception.launch

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@tkimura4 @boyali
feat: add option to use validator node in detection module (tier4#1233)
b3d23f7 
* feat: add option to use validator node in detection module

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* remove use_validator option in detection/perception.launch

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@tkimura4 @boyali
feat: add option to use validator node in detection module (tier4#1233)
5240203 
* feat: add option to use validator node in detection module

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* remove use_validator option in detection/perception.launch

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
@tkimura4
feat: add option to use validator node in detection module (autowaref…
d35d059 
…oundation#1233)

* feat: add option to use validator node in detection module

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* remove use_validator option in detection/perception.launch

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@tkimura4 @boyali
feat: add option to use validator node in detection module (tier4#1233)
430f5e4 
* feat: add option to use validator node in detection module

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* remove use_validator option in detection/perception.launch

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkimura4 @yukkysaito