Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): reset modified goal id #3095

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Mar 16, 2023

Description

Fix the problem that modified goal is not published when receiving new route before modifying the goal

Related links

Tests performed

psim

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 16, 2023
Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.26 ⚠️

Comparison is base (0d4e444) 11.86% compared to head (a6df517) 11.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3095      +/-   ##
==========================================
- Coverage   11.86%   11.61%   -0.26%     
==========================================
  Files        1333     1333              
  Lines       92786    94827    +2041     
  Branches    24649    26134    +1485     
==========================================
+ Hits        11011    11015       +4     
- Misses      70364    72237    +1873     
- Partials    11411    11575     +164     
Flag Coverage Δ *Carryforward flag
differential 5.55% <ø> (?)
total 11.86% <ø> (ø) Carriedforward from 0d4e444

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <ø> (ø)

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit fd090cb into autowarefoundation:main Mar 16, 2023
@kosuke55 kosuke55 deleted the fix/reset_modifed_goal branch March 16, 2023 16:06
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Mar 16, 2023
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants