Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(autoware_auto_geometry): fix link to paper #3077

Merged
merged 3 commits into from
May 19, 2023

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Mar 14, 2023

Description

Fixes #2966

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@esteve esteve requested a review from a team as a code owner March 14, 2023 11:45
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) labels Mar 14, 2023
@esteve esteve marked this pull request as draft March 14, 2023 11:51
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3f63c15) 14.51% compared to head (0c100ac) 14.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3077   +/-   ##
=======================================
  Coverage   14.51%   14.51%           
=======================================
  Files        1439     1439           
  Lines      101307   101307           
  Branches    30061    30061           
=======================================
  Hits        14708    14708           
  Misses      70510    70510           
  Partials    16089    16089           
Flag Coverage Δ *Carryforward flag
differential 62.73% <ø> (?)
total 14.51% <ø> (ø) Carriedforward from 3f63c15

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota self-requested a review March 26, 2023 07:35
@satoshi-ota satoshi-ota changed the title fix: fix link to paper docs(autoware_auto_geometry): fix link to paper May 15, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review May 15, 2023 23:46
@satoshi-ota
Copy link
Contributor

@esteve I confirmed the error is fixed.

image

@satoshi-ota
Copy link
Contributor

I'll fix the other errors in other PR.

esteve and others added 3 commits May 19, 2023 09:01
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota merged commit 4b69943 into autowarefoundation:main May 19, 2023
@esteve esteve deleted the fix-doc-link branch May 19, 2023 10:11
@esteve
Copy link
Contributor Author

esteve commented May 19, 2023

@satoshi-ota thanks! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dead link in autoware_auto_geometry README
2 participants