-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(interpolation): query key is out of range due to double calculation error #2204
fix(interpolation): query key is out of range due to double calculation error #2204
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 10.88% // Head: 10.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2204 +/- ##
==========================================
+ Coverage 10.88% 10.91% +0.03%
==========================================
Files 1179 1179
Lines 84935 84970 +35
Branches 20043 20075 +32
==========================================
+ Hits 9242 9272 +30
+ Misses 65931 65911 -20
- Partials 9762 9787 +25
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…on error (autowarefoundation#2204) * fix issue sligtly out of range due to double's calculation error Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update test Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…on error (autowarefoundation#2204) * fix issue sligtly out of range due to double's calculation error Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update test Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Description
This range check sometimes fails even in a normal case due to calculation error of double, resulting in the node dying.
autoware.universe/common/interpolation/include/interpolation/interpolation_utils.hpp
Line 74 in d10310d
To fix this issue, I created this PR.
If the query key's violation from the range of base_keys is epsilon, it is judged as valid and cropped to be inside the range of base_keys.
TIER IV internal link
https://tier4.atlassian.net/browse/T4PB-22737
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.