Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(osqp_interface): add warm startup interface #2180

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Oct 31, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

Add warm startup interface to the osqp interface module to enable it to set primal and dual variables.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 10.84% // Head: 10.87% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (5993b3c) compared to base (89fef41).
Patch coverage: 31.64% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2180      +/-   ##
==========================================
+ Coverage   10.84%   10.87%   +0.03%     
==========================================
  Files        1178     1178              
  Lines       84780    84872      +92     
  Branches    19952    20021      +69     
==========================================
+ Hits         9196     9233      +37     
- Misses      65879    65894      +15     
- Partials     9705     9745      +40     
Flag Coverage Δ *Carryforward flag
differential 11.21% <15.68%> (?)
total 10.82% <46.34%> (ø) Carriedforward from 3d0ad89

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nterface/include/osqp_interface/osqp_interface.hpp 0.00% <0.00%> (ø)
common/osqp_interface/test/test_osqp_interface.cpp 15.00% <9.09%> (-2.25%) ⬇️
common/osqp_interface/src/osqp_interface.cpp 39.67% <41.81%> (+4.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good but can you add a few tests for the new functions ?
It would also be interesting to have an example with/without warm start to compare the results.

@purewater0901
Copy link
Contributor Author

@maxime-clem How do I test my code? Do you have any suggestions?

@maxime-clem
Copy link
Contributor

Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901
Copy link
Contributor Author

@maxime-clem I just added a test to the file. Could you check it please?

Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good. Thank you for adding the test.

@purewater0901 purewater0901 enabled auto-merge (squash) November 1, 2022 03:53
@purewater0901 purewater0901 merged commit a85f288 into autowarefoundation:main Nov 1, 2022
@purewater0901 purewater0901 deleted the feat/add-warmstarup-api branch November 1, 2022 04:04
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…2180)

* feat(osqp_interface): add warm startup interface

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants