-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(osqp_interface): add warm startup interface #2180
feat(osqp_interface): add warm startup interface #2180
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
Codecov ReportBase: 10.84% // Head: 10.87% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2180 +/- ##
==========================================
+ Coverage 10.84% 10.87% +0.03%
==========================================
Files 1178 1178
Lines 84780 84872 +92
Branches 19952 20021 +69
==========================================
+ Hits 9196 9233 +37
- Misses 65879 65894 +15
- Partials 9705 9745 +40
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good but can you add a few tests for the new functions ?
It would also be interesting to have an example with/without warm start to compare the results.
@maxime-clem How do I test my code? Do you have any suggestions? |
You can either extend the existing test (https://github.com/autowarefoundation/autoware.universe/blob/3d0ad89aaa27072a1a7a16598953522fbdf3b90e/common/osqp_interface/test/test_osqp_interface.cpp) or add a new one. |
@maxime-clem I just added a test to the file. Could you check it please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good. Thank you for adding the test.
…2180) * feat(osqp_interface): add warm startup interface Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: yutaka purewater0901@gmail.com
Description
Add warm startup interface to the osqp interface module to enable it to set primal and dual variables.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.