Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ekf_localizer): add a struct to load hyper parameters #2107

Merged
merged 5 commits into from
Nov 1, 2022

Conversation

IshitaTakeshi
Copy link
Contributor

@IshitaTakeshi IshitaTakeshi commented Oct 19, 2022

Description

I summarized hyper-parameter constants into a struct to simplify initialization

Related links

Tests performed

Not tested yet.

Notes for reviewers

I initialized ekf_dt in the hyper-parameter struct but we can consider initializing it in the EKFLocalizer class.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@IshitaTakeshi IshitaTakeshi added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Oct 19, 2022
@IshitaTakeshi IshitaTakeshi changed the title Add a struct to load hyper parameters refactor(ekf_localizer): add a struct to load hyper parameters Oct 19, 2022
@IshitaTakeshi IshitaTakeshi marked this pull request as draft October 19, 2022 03:36
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 10.84% // Head: 10.34% // Decreases project coverage by -0.49% ⚠️

Coverage data is based on head (20c5748) compared to base (4fcc6da).
Patch coverage: 19.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2107      +/-   ##
==========================================
- Coverage   10.84%   10.34%   -0.50%     
==========================================
  Files        1178     1176       -2     
  Lines       84781    84237     -544     
  Branches    19950    19791     -159     
==========================================
- Hits         9196     8717     -479     
+ Misses      66016    65959      -57     
+ Partials     9569     9561       -8     
Flag Coverage Δ *Carryforward flag
differential 18.21% <0.00%> (?)
total 10.35% <31.14%> (-0.47%) ⬇️ Carriedforward from bb42d22

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nterface/include/osqp_interface/osqp_interface.hpp 0.00% <0.00%> (ø)
..._localizer/include/ekf_localizer/ekf_localizer.hpp 0.00% <ø> (ø)
...calizer/include/ekf_localizer/hyper_parameters.hpp 0.00% <0.00%> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <0.00%> (ø)
common/osqp_interface/src/osqp_interface.cpp 35.39% <47.36%> (ø)
common/osqp_interface/test/test_osqp_interface.cpp 17.24% <100.00%> (ø)
...lude/freespace_planning_algorithms/reeds_shepp.hpp 50.00% <0.00%> (-50.00%) ⬇️
.../freespace_planning_algorithms/src/reeds_shepp.cpp 55.51% <0.00%> (-38.97%) ⬇️
...lude/behavior_path_planner/turn_signal_decider.hpp 50.00% <0.00%> (-35.72%) ⬇️
...eespace_planning_algorithms/abstract_algorithm.hpp 44.44% <0.00%> (-25.56%) ⬇️
... and 208 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@IshitaTakeshi IshitaTakeshi marked this pull request as ready for review October 19, 2022 03:42
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IshitaTakeshi IshitaTakeshi merged commit 0a4718d into main Nov 1, 2022
@IshitaTakeshi IshitaTakeshi deleted the refactor/hyper-parameters branch November 1, 2022 05:20
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…arefoundation#2107)

* Add a hyper-parameter class to simplify parameter loading

Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants