-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ekf_localizer): add a struct to load hyper parameters #2107
Conversation
Codecov ReportBase: 10.84% // Head: 10.34% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2107 +/- ##
==========================================
- Coverage 10.84% 10.34% -0.50%
==========================================
Files 1178 1176 -2
Lines 84781 84237 -544
Branches 19950 19791 -159
==========================================
- Hits 9196 8717 -479
+ Misses 66016 65959 -57
+ Partials 9569 9561 -8
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…arefoundation#2107) * Add a hyper-parameter class to simplify parameter loading Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Description
I summarized hyper-parameter constants into a struct to simplify initialization
Related links
Tests performed
Not tested yet.
Notes for reviewers
I initialized
ekf_dt
in the hyper-parameter struct but we can consider initializing it in the EKFLocalizer class.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.