-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): drivable area extended while avoidance #1688
fix(behavior_path_planner): drivable area extended while avoidance #1688
Conversation
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
I checked
|
Codecov Report
@@ Coverage Diff @@
## main #1688 +/- ##
==========================================
- Coverage 10.72% 10.64% -0.08%
==========================================
Files 1103 1103
Lines 78416 78987 +571
Branches 18648 19052 +404
==========================================
+ Hits 8409 8410 +1
- Misses 61093 61604 +511
- Partials 8914 8973 +59
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…utowarefoundation#1688) * fix(behavior_path_planner): drivable area extended while avoidance Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix empty lanelet issue Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add cv empty path check from Tanaka-san's suggestion Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…utowarefoundation#1688) * fix(behavior_path_planner): drivable area extended while avoidance Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix empty lanelet issue Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add cv empty path check from Tanaka-san's suggestion Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…utowarefoundation#1688) * fix(behavior_path_planner): drivable area extended while avoidance Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix empty lanelet issue Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add cv empty path check from Tanaka-san's suggestion Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…utowarefoundation#1688) * fix(behavior_path_planner): drivable area extended while avoidance Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix empty lanelet issue Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add cv empty path check from Tanaka-san's suggestion Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…utowarefoundation#1688) * fix(behavior_path_planner): drivable area extended while avoidance Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix empty lanelet issue Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add cv empty path check from Tanaka-san's suggestion Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…utowarefoundation#1688) * fix(behavior_path_planner): drivable area extended while avoidance Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix empty lanelet issue Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add cv empty path check from Tanaka-san's suggestion Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Description
The drivable area is not well expanded if only considering the obstacle's direction.
This is because, if the obstacle direction is lost, the drivable area will lost, and it will cause the ego vehicle to suddenly reduces its speed.
This PR aims to solve this by expanding the drivable area with respect to current lane, instead of object direction. This reduces the complexity and ensures the drivable area to be expanded as long as avoidance module is on.
Before this PR (Drivable area not included after the obstacle)
With this PR
2022-08-25-17-39-19.mp4
Related links
#1544
Tests performed
Use PSIM and test avoidance module. It is recommended that the lanelet has opposite direction.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.