Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): drivable area extended while avoidance #1688

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Description

The drivable area is not well expanded if only considering the obstacle's direction.
This is because, if the obstacle direction is lost, the drivable area will lost, and it will cause the ego vehicle to suddenly reduces its speed.

This PR aims to solve this by expanding the drivable area with respect to current lane, instead of object direction. This reduces the complexity and ensures the drivable area to be expanded as long as avoidance module is on.

Before this PR (Drivable area not included after the obstacle)
image

With this PR

2022-08-25-17-39-19.mp4

Related links

#1544

Tests performed

Use PSIM and test avoidance module. It is recommended that the lanelet has opposite direction.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 25, 2022
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 self-assigned this Aug 25, 2022
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 changed the title Fix/drivable area removed while avoidance not completed bug fix(behavior_path_planner): drivable area extended while avoidance Aug 25, 2022
@taikitanaka3
Copy link
Contributor

taikitanaka3 commented Aug 25, 2022

I checked

  1. nominal case
    https://user-images.githubusercontent.com/65527974/186623107-9e1293bb-947a-4c23-8637-2ad7d7a4945f.mp4
  2. shared line string
    https://user-images.githubusercontent.com/65527974/186623583-e319727e-919c-4091-88dd-a97485524dc1.mp4
  3. not avoidable(Note : this bug was rare case and happned only once so keep searching this for another PR if happened next time)
    image
[planning.scenario_planning.lane_driving.behavior_planning.behavior_path_planner.LaneFollowing]: behavior module has failed with exception: vector::_M_range_check: __n (which is 0) >= this->size() (which is 0)

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1688 (0520de8) into main (fcf1302) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
- Coverage   10.72%   10.64%   -0.08%     
==========================================
  Files        1103     1103              
  Lines       78416    78987     +571     
  Branches    18648    19052     +404     
==========================================
+ Hits         8409     8410       +1     
- Misses      61093    61604     +511     
- Partials     8914     8973      +59     
Flag Coverage Δ *Carryforward flag
differential 0.79% <0.00%> (?)
total 10.70% <0.00%> (ø) Carriedforward from fcf1302

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 0.85% <0.00%> (-0.20%) ⬇️
...or_path_planner/src/behavior_path_planner_node.cpp 0.35% <0.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 merged commit 25ba37d into autowarefoundation:main Aug 25, 2022
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix/drivable_area_removed_while_avoidance_not_completed_bug branch August 25, 2022 09:46
taikitanaka3 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 25, 2022
…utowarefoundation#1688)

* fix(behavior_path_planner): drivable area extended while avoidance

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix empty lanelet issue

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* add cv empty path check from Tanaka-san's suggestion

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…utowarefoundation#1688)

* fix(behavior_path_planner): drivable area extended while avoidance

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix empty lanelet issue

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* add cv empty path check from Tanaka-san's suggestion

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…utowarefoundation#1688)

* fix(behavior_path_planner): drivable area extended while avoidance

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix empty lanelet issue

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* add cv empty path check from Tanaka-san's suggestion

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…utowarefoundation#1688)

* fix(behavior_path_planner): drivable area extended while avoidance

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix empty lanelet issue

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* add cv empty path check from Tanaka-san's suggestion

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…utowarefoundation#1688)

* fix(behavior_path_planner): drivable area extended while avoidance

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix empty lanelet issue

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* add cv empty path check from Tanaka-san's suggestion

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…utowarefoundation#1688)

* fix(behavior_path_planner): drivable area extended while avoidance

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix empty lanelet issue

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* add cv empty path check from Tanaka-san's suggestion

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants