Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_datetime_rviz_plugin): apply clang-tidy #1605

Merged

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Aug 17, 2022

Description

  • fix modernize-use-auto
  • fix readability-identifier-naming (I can revert if you don't feel like to merge it)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta force-pushed the refactor/tier4_datetime_rviz_plugin branch 2 times, most recently from 85b14fd to 629bb72 Compare August 17, 2022 06:31
@h-ohta h-ohta force-pushed the refactor/tier4_datetime_rviz_plugin branch from 629bb72 to 07a2f93 Compare August 17, 2022 06:58
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #1605 (07a2f93) into main (41e2c99) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1605   +/-   ##
=======================================
  Coverage   10.77%   10.77%           
=======================================
  Files        1111     1111           
  Lines       78527    78527           
  Branches    18552    18552           
=======================================
  Hits         8460     8460           
  Misses      61207    61207           
  Partials     8860     8860           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.75% <0.00%> (ø) Carriedforward from 41e2c99

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...tetime_rviz_plugin/src/autoware_datetime_panel.cpp 0.00% <0.00%> (ø)
...er4_state_rviz_plugin/src/autoware_state_panel.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@h-ohta h-ohta marked this pull request as ready for review August 17, 2022 09:52
@h-ohta h-ohta merged commit 9f451b4 into autowarefoundation:main Aug 17, 2022
@h-ohta h-ohta deleted the refactor/tier4_datetime_rviz_plugin branch August 18, 2022 10:07
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* refactor(tier4_datetime_rviz_plugin): apply clang-tidy

* refactor: apply readability-identifier-naming
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* refactor(tier4_datetime_rviz_plugin): apply clang-tidy

* refactor: apply readability-identifier-naming
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* refactor(tier4_datetime_rviz_plugin): apply clang-tidy

* refactor: apply readability-identifier-naming
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ation#1605)

* refactor(tier4_datetime_rviz_plugin): apply clang-tidy

* refactor: apply readability-identifier-naming
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* refactor(tier4_datetime_rviz_plugin): apply clang-tidy

* refactor: apply readability-identifier-naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants