Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perception_utils): add maximum size boundary #1437

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Jul 26, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

The resampling function is the predicted path utils file will be collapsed when resampled size is over the maximum size of the predicted path. In this PR, I add the upper bound for the resampled path size to avoid the collapse of the code.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #1437 (d5ba5a4) into main (a474154) will increase coverage by 0.01%.
The diff coverage is 39.13%.

@@            Coverage Diff             @@
##             main    #1437      +/-   ##
==========================================
+ Coverage   10.11%   10.12%   +0.01%     
==========================================
  Files        1116     1116              
  Lines       77410    77455      +45     
  Branches    17987    18036      +49     
==========================================
+ Hits         7827     7843      +16     
  Misses      62146    62146              
- Partials     7437     7466      +29     
Flag Coverage Δ *Carryforward flag
differential 10.43% <26.31%> (?)
total 10.09% <46.15%> (ø) Carriedforward from a474154

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ption_utils/test/src/test_predicted_path_utils.cpp 24.09% <33.33%> (+0.70%) ⬆️
.../include/perception_utils/predicted_path_utils.hpp 56.66% <60.00%> (+5.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a474154...d5ba5a4. Read the comment docs.

@purewater0901 purewater0901 merged commit 564c781 into autowarefoundation:main Jul 26, 2022
@purewater0901 purewater0901 deleted the feat/add-max-size-to-resampling branch July 26, 2022 14:56
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants