Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(detected_object_validation): use common utils #1410

Merged
merged 1 commit into from
Jul 25, 2022
Merged

refactor(detected_object_validation): use common utils #1410

merged 1 commit into from
Jul 25, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 25, 2022 •
edited
Loading

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

use perception_utils and tier4_autoware_utils

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168
refactor(detected_object_validation): use common utils
806cb6a 
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review July 25, 2022 03:56
@codecov
Copy link

codecov bot commented Jul 25, 2022 •
edited
Loading

Codecov Report

Merging #1410 (806cb6a) into main (f83e489) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1410      +/-   ##
========================================
- Coverage   9.75%   9.73%   -0.02%     
========================================
  Files       1115    1115              
  Lines      77372   77516     +144     
  Branches   17664   17664              
========================================
  Hits        7545    7545              
- Misses     62649   62793     +144     
  Partials    7178    7178
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.73% <0.00%> (ø) Carriedforward from f83e489

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ed_object_validation/src/object_lanelet_filter.cpp 0.00% <0.00%> (ø)
...dation/src/obstacle_pointcloud_based_validator.cpp 0.00% <0.00%> (ø)
..._validation/src/occupancy_grid_based_validator.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ad83a...806cb6a. Read the comment docs.

yukkysaito
yukkysaito approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit 9eb890a into autowarefoundation:main Jul 25, 2022
@takayuki5168 takayuki5168 deleted the refactor/validation-with-perception-utils branch July 25, 2022 06:21
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 26, 2022
Merged
yukke42 referenced this pull request in tier4/autoware.universe Aug 9, 2022
@takayuki5168 @yukke42
refactor(detected_object_validation): use common utils (#1410)
71d3c89 
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@takayuki5168 @boyali
refactor(detected_object_validation): use common utils (tier4#1410)
aa9e5e6 
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@takayuki5168 @boyali
refactor(detected_object_validation): use common utils (tier4#1410)
4d3ee1f 
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@takayuki5168 @boyali
refactor(detected_object_validation): use common utils (tier4#1410)
3810f86 
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
@takayuki5168
refactor(detected_object_validation): use common utils (autowarefound…
ba9bac3 
…ation#1410)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@takayuki5168 @boyali
refactor(detected_object_validation): use common utils (tier4#1410)
b07393a 
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
shtokuda pushed a commit to shtokuda/autoware.universe that referenced this pull request Jul 12, 2024
@tkimura4 @dkoldaev
feat(duplicated_node_checker): add duplicate nodes to ignore (autowar…
898eb5a 
…efoundation#7959) (autowarefoundation#1410)

* feat: add duplicate nodes to ignore



* remove talker



* newline



* commments



* pre-commit and sign



* rviz->rviz2



---------

Signed-off-by: Dmitrii Koldaev <dmitrii.koldaev@tier4.jp>
Co-authored-by: Dmitrii Koldaev <39071246+dkoldaev@users.noreply.github.com>
Co-authored-by: Dmitrii Koldaev <dmitrii.koldaev@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@miursh miursh Awaiting requested review from miursh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takayuki5168 @yukkysaito