Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(obstacle_cruise_planner): use polygon utils #1406

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 25, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review July 25, 2022 04:03
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1406 (f2170d6) into main (01ad83a) will decrease coverage by 0.52%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             main   #1406      +/-   ##
=========================================
- Coverage   10.23%   9.71%   -0.53%     
=========================================
  Files        1044    1115      +71     
  Lines       68731   77680    +8949     
  Branches    17237   17664     +427     
=========================================
+ Hits         7035    7545     +510     
- Misses      54866   62957    +8091     
- Partials     6830    7178     +348     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.73% <0.00%> (-0.51%) ⬇️ Carriedforward from f83e489

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
...ning/obstacle_cruise_planner/src/polygon_utils.cpp 0.00% <0.00%> (ø)
...lude/freespace_planning_algorithms/reeds_shepp.hpp 50.00% <0.00%> (-50.00%) ⬇️
...tic_evaluator/include/kinematic_evaluator/stat.hpp 62.50% <0.00%> (-19.32%) ⬇️
..._evaluator/include/localization_evaluator/stat.hpp 56.25% <0.00%> (-16.48%) ⬇️
.../src/vehicle/test_vehicle_state_checker_helper.hpp 70.58% <0.00%> (-9.42%) ⬇️
planning/behavior_path_planner/test/input.cpp 60.00% <0.00%> (-7.86%) ⬇️
...include/motion_utils/trajectory/tmp_conversion.hpp 60.00% <0.00%> (-6.67%) ⬇️
...oware_auto_geometry/include/geometry/common_2d.hpp 82.66% <0.00%> (-5.91%) ⬇️
...nning/behavior_velocity_planner/test/src/utils.hpp 82.22% <0.00%> (-5.59%) ⬇️
... and 769 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ad83a...f2170d6. Read the comment docs.

Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit 1622892 into autowarefoundation:main Jul 25, 2022
@takayuki5168 takayuki5168 deleted the feat/obstacle-cruise-polygon-utils branch July 25, 2022 07:20
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* refactor(obstacle_cruise_planner): use polygon utils

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* refactor(obstacle_cruise_planner): use polygon utils

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* refactor(obstacle_cruise_planner): use polygon utils

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ion#1406)

* refactor(obstacle_cruise_planner): use polygon utils

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 17, 2022
* refactor(obstacle_cruise_planner): use polygon utils

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* refactor(obstacle_cruise_planner): use polygon utils

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
shtokuda pushed a commit to shtokuda/autoware.universe that referenced this pull request Jul 12, 2024
autowarefoundation#1406)

fix(multi_object_tracker): calculation of detection delay diagnostics (autowarefoundation#1317)

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants