Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner): remove unused utils functions #1383

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 20, 2022

Description

  • remove unused utils functions
  • use alias (clean up)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota satoshi-ota requested a review from TakaHoribe July 20, 2022 08:31
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #1383 (14da623) into main (fb88141) will increase coverage by 0.03%.
The diff coverage is 17.94%.

@@           Coverage Diff            @@
##            main   #1383      +/-   ##
========================================
+ Coverage   9.93%   9.97%   +0.03%     
========================================
  Files       1117    1117              
  Lines      77941   78128     +187     
  Branches   18117   18218     +101     
========================================
+ Hits        7747    7795      +48     
- Misses     62883   63013     +130     
- Partials    7311    7320       +9     
Flag Coverage Δ *Carryforward flag
differential 9.56% <8.69%> (?)
total 9.92% <20.83%> (ø) Carriedforward from fb88141

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...vior_velocity_planner/include/utilization/util.hpp 4.16% <10.52%> (ø)
...behavior_velocity_planner/src/utilization/util.cpp 26.40% <25.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb88141...14da623. Read the comment docs.

@satoshi-ota satoshi-ota force-pushed the fix/remove-unused-util-func branch from c809bbf to eb699c2 Compare July 21, 2022 04:48
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the fix/remove-unused-util-func branch from eb699c2 to 14da623 Compare July 22, 2022 01:05
Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit f83e489 into autowarefoundation:main Jul 24, 2022
@satoshi-ota satoshi-ota deleted the fix/remove-unused-util-func branch July 24, 2022 22:17
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…1383)

* fix(behavior_velocity_planner): remove unused util functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(behavior_velocity_planner): use alias

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(motion_utils): remove path_with_lane_id.hpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…1383)

* fix(behavior_velocity_planner): remove unused util functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(behavior_velocity_planner): use alias

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(motion_utils): remove path_with_lane_id.hpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…1383)

* fix(behavior_velocity_planner): remove unused util functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(behavior_velocity_planner): use alias

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(motion_utils): remove path_with_lane_id.hpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 13, 2022
* fix(behavior_velocity_planner): remove unused util functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(behavior_velocity_planner): use alias

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(motion_utils): remove path_with_lane_id.hpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 13, 2022
* fix(behavior_velocity_planner): remove unused util functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(behavior_velocity_planner): use alias

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(motion_utils): remove path_with_lane_id.hpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…refoundation#1383)

* fix(behavior_velocity_planner): remove unused util functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(behavior_velocity_planner): use alias

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(motion_utils): remove path_with_lane_id.hpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 18, 2022
* fix(behavior_velocity_planner): remove unused util functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(behavior_velocity_planner): use alias

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(motion_utils): remove path_with_lane_id.hpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…1383)

* fix(behavior_velocity_planner): remove unused util functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(behavior_velocity_planner): use alias

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(motion_utils): remove path_with_lane_id.hpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Nov 10, 2022
* fix(behavior_velocity_planner): remove unused util functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(behavior_velocity_planner): use alias

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(motion_utils): remove path_with_lane_id.hpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Nov 30, 2022
* fix(behavior_velocity_planner): remove unused util functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(behavior_velocity_planner): use alias

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(motion_utils): remove path_with_lane_id.hpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
yn-mrse referenced this pull request in tier4/autoware.universe Jun 22, 2023
Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
yn-mrse referenced this pull request in tier4/autoware.universe Jun 23, 2023
…609)

* feat: move alias polygons2d

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>

* feat: add alias same as #1383

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>

* fix: replace motion_utils to tier4_autoware_utils

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>

* ci(pre-commit): autofix

---------

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Oct 28, 2024
chore: sync tier4/autoware.universe:awf-latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants