Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): change the condition of updateRTCStatus() in avoidance module #1361

Merged
merged 3 commits into from
Aug 1, 2022
Merged

fix(behavior_path_planner): change the condition of updateRTCStatus() in avoidance module #1361

merged 3 commits into from
Aug 1, 2022

Conversation

shulanbushangshu
Copy link
Contributor

@shulanbushangshu shulanbushangshu commented Jul 15, 2022

Description

When the updateRTCStatus() function registers the obstacle avoidance direction, the relative offset calculated by the planCandidate() function will be used as the condition.
But there will be problems when planCandidate() calculates the relative offset.Currently, there are multiple obstacle avoidance points registered at one time, and the relative offset of the last obstacle avoidance point is 0.0.
So the calculation of the offset direction is wrong. An error occurred while updateRTCStatus() was registering.
When updateRTCStatus() has the erro,Obstacle avoidance will not happen .

Related links

Tests performed

Current simulation:
rtc_nono
rtc_no

I change the lateral_shift in the planCandidate() function then simulate:
rtc_change

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: jack.song <jack.song@autocore.ai>
…oidance_module

Signed-off-by: jack.song <jack.song@autocore.ai>
@shulanbushangshu shulanbushangshu changed the title Change condition of update rtc status in avoidance module fix(behavior_path_planner): Change condition of update rtc status in avoidance module Jul 15, 2022
@shulanbushangshu shulanbushangshu changed the title fix(behavior_path_planner): Change condition of update rtc status in avoidance module fix(behavior_path_planner): change the condition of updateRTCStatus() in avoidance module Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #1361 (f8ad3aa) into main (db01212) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1361      +/-   ##
========================================
- Coverage   9.51%   9.34%   -0.18%     
========================================
  Files       1096    1096              
  Lines      76148   77591    +1443     
  Branches   16991   18030    +1039     
========================================
+ Hits        7244    7248       +4     
- Misses     62292   63605    +1313     
- Partials    6612    6738     +126     
Flag Coverage Δ *Carryforward flag
differential 0.79% <0.00%> (?)
total 9.49% <0.00%> (ø) Carriedforward from 323137f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/avoidance/avoidance_utils.cpp 2.40% <0.00%> (-0.52%) ⬇️
planning/behavior_path_planner/src/utilities.cpp 1.02% <0.00%> (-0.04%) ⬇️
...r_path_planner/src/scene_module/pull_over/util.cpp 0.00% <0.00%> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)
.../src/scene_module/side_shift/side_shift_module.cpp 0.00% <0.00%> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
...rc/scene_module/scene_module_bt_node_interface.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db01212...f8ad3aa. Read the comment docs.

@shulanbushangshu shulanbushangshu requested review from yukkysaito and tkimura4 and removed request for taikitanaka3 July 18, 2022 01:56
@shulanbushangshu
Copy link
Contributor Author

shulanbushangshu commented Jul 18, 2022

@rej55 @yukkysaito @tkimura4

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit d8c1740 into autowarefoundation:main Aug 1, 2022
tkimura4 referenced this pull request in tier4/autoware.universe Aug 1, 2022
… in avoidance module (#1361)

* change-condition-of-updateRTCStatus-in-avoidance_module

Signed-off-by: jack.song <jack.song@autocore.ai>

* fix(behavior_path_planner): change-condition-of-updateRTCStatus-in-avoidance_module

Signed-off-by: jack.song <jack.song@autocore.ai>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
… in avoidance module (tier4#1361)

* change-condition-of-updateRTCStatus-in-avoidance_module

Signed-off-by: jack.song <jack.song@autocore.ai>

* fix(behavior_path_planner): change-condition-of-updateRTCStatus-in-avoidance_module

Signed-off-by: jack.song <jack.song@autocore.ai>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
… in avoidance module (tier4#1361)

* change-condition-of-updateRTCStatus-in-avoidance_module

Signed-off-by: jack.song <jack.song@autocore.ai>

* fix(behavior_path_planner): change-condition-of-updateRTCStatus-in-avoidance_module

Signed-off-by: jack.song <jack.song@autocore.ai>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
… in avoidance module (tier4#1361)

* change-condition-of-updateRTCStatus-in-avoidance_module

Signed-off-by: jack.song <jack.song@autocore.ai>

* fix(behavior_path_planner): change-condition-of-updateRTCStatus-in-avoidance_module

Signed-off-by: jack.song <jack.song@autocore.ai>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
… in avoidance module (autowarefoundation#1361)

* change-condition-of-updateRTCStatus-in-avoidance_module

Signed-off-by: jack.song <jack.song@autocore.ai>

* fix(behavior_path_planner): change-condition-of-updateRTCStatus-in-avoidance_module

Signed-off-by: jack.song <jack.song@autocore.ai>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
… in avoidance module (tier4#1361)

* change-condition-of-updateRTCStatus-in-avoidance_module

Signed-off-by: jack.song <jack.song@autocore.ai>

* fix(behavior_path_planner): change-condition-of-updateRTCStatus-in-avoidance_module

Signed-off-by: jack.song <jack.song@autocore.ai>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Jul 2, 2024
…f-out_of_lane

perf(motion_velocity_planner): resample trajectory and build rtree with packing algorithm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants