-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): change the condition of updateRTCStatus() in avoidance module #1361
fix(behavior_path_planner): change the condition of updateRTCStatus() in avoidance module #1361
Conversation
Signed-off-by: jack.song <jack.song@autocore.ai>
…oidance_module Signed-off-by: jack.song <jack.song@autocore.ai>
Codecov Report
@@ Coverage Diff @@
## main #1361 +/- ##
========================================
- Coverage 9.51% 9.34% -0.18%
========================================
Files 1096 1096
Lines 76148 77591 +1443
Branches 16991 18030 +1039
========================================
+ Hits 7244 7248 +4
- Misses 62292 63605 +1313
- Partials 6612 6738 +126
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… in avoidance module (#1361) * change-condition-of-updateRTCStatus-in-avoidance_module Signed-off-by: jack.song <jack.song@autocore.ai> * fix(behavior_path_planner): change-condition-of-updateRTCStatus-in-avoidance_module Signed-off-by: jack.song <jack.song@autocore.ai> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… in avoidance module (tier4#1361) * change-condition-of-updateRTCStatus-in-avoidance_module Signed-off-by: jack.song <jack.song@autocore.ai> * fix(behavior_path_planner): change-condition-of-updateRTCStatus-in-avoidance_module Signed-off-by: jack.song <jack.song@autocore.ai> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… in avoidance module (tier4#1361) * change-condition-of-updateRTCStatus-in-avoidance_module Signed-off-by: jack.song <jack.song@autocore.ai> * fix(behavior_path_planner): change-condition-of-updateRTCStatus-in-avoidance_module Signed-off-by: jack.song <jack.song@autocore.ai> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… in avoidance module (tier4#1361) * change-condition-of-updateRTCStatus-in-avoidance_module Signed-off-by: jack.song <jack.song@autocore.ai> * fix(behavior_path_planner): change-condition-of-updateRTCStatus-in-avoidance_module Signed-off-by: jack.song <jack.song@autocore.ai> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… in avoidance module (autowarefoundation#1361) * change-condition-of-updateRTCStatus-in-avoidance_module Signed-off-by: jack.song <jack.song@autocore.ai> * fix(behavior_path_planner): change-condition-of-updateRTCStatus-in-avoidance_module Signed-off-by: jack.song <jack.song@autocore.ai> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… in avoidance module (tier4#1361) * change-condition-of-updateRTCStatus-in-avoidance_module Signed-off-by: jack.song <jack.song@autocore.ai> * fix(behavior_path_planner): change-condition-of-updateRTCStatus-in-avoidance_module Signed-off-by: jack.song <jack.song@autocore.ai> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…f-out_of_lane perf(motion_velocity_planner): resample trajectory and build rtree with packing algorithm
Description
When the updateRTCStatus() function registers the obstacle avoidance direction, the relative offset calculated by the planCandidate() function will be used as the condition.
But there will be problems when planCandidate() calculates the relative offset.Currently, there are multiple obstacle avoidance points registered at one time, and the relative offset of the last obstacle avoidance point is 0.0.
So the calculation of the offset direction is wrong. An error occurred while updateRTCStatus() was registering.
When updateRTCStatus() has the erro,Obstacle avoidance will not happen .
Related links
Tests performed
Current simulation:
I change the lateral_shift in the planCandidate() function then simulate:
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.