-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_autoware_utils): add new orientation calculation #1126
feat(tier4_autoware_utils): add new orientation calculation #1126
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1126 +/- ##
========================================
+ Coverage 9.04% 9.10% +0.06%
========================================
Files 1031 1029 -2
Lines 69974 70045 +71
Branches 14597 14643 +46
========================================
+ Hits 6327 6378 +51
+ Misses 58227 58212 -15
- Partials 5420 5455 +35
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
geometry_msgs::msg::Pose src_pose; | ||
src_pose.position = createPoint(0.0, 0.0, 0.0); | ||
src_pose.orientation = createQuaternionFromRPY(deg2rad(0), deg2rad(0), deg2rad(0)); | ||
{{geometry_msgs::msg::Pose src_pose; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unusual shape, but CI has passed...hmm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He asked me about that in another PR. Removing one pair of {}
can solve this format collapse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Note, this function is still a new one, not used anywhere.
* feat(tier4_autoware_utils): add new orientation calculation Signed-off-by: yutaka <purewater0901@gmail.com> * fix format
* feat(tier4_autoware_utils): add new orientation calculation Signed-off-by: yutaka <purewater0901@gmail.com> * fix format
* feat(tier4_autoware_utils): add new orientation calculation Signed-off-by: yutaka <purewater0901@gmail.com> * fix format
* feat(tier4_autoware_utils): add new orientation calculation Signed-off-by: yutaka <purewater0901@gmail.com> * fix format
* feat(tier4_autoware_utils): add new orientation calculation Signed-off-by: yutaka <purewater0901@gmail.com> * fix format
* feat(tier4_autoware_utils): add new orientation calculation Signed-off-by: yutaka <purewater0901@gmail.com> * fix format
#1100, #1126) (#592) * feat(tier4_autoware_utils): add pose interpolation function (#1097) Signed-off-by: yutaka <purewater0901@gmail.com> * feat(tier4_autoware_utils): add new orientation calculation (#1126) * feat(tier4_autoware_utils): add new orientation calculation Signed-off-by: yutaka <purewater0901@gmail.com> * fix format * feat(tier4_autoware_utils): add point interpolation function (#1100) --------- Signed-off-by: yutaka <purewater0901@gmail.com> Co-authored-by: Yutaka Shimizu <43805014+purewater0901@users.noreply.github.com>
…on/refactor_pointcloud_container feat(perception): refactor pointcloud container
Signed-off-by: yutaka purewater0901@gmail.com
Description
Add a new option to calculate the interpolated pose orientation
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.