feat: add radar tracks msgs converter #1012

scepter914 · 2022-05-31T16:29:36Z

Description

Make radar_tracks_msgs_converter, new feature for radar perception.

Tests performed

Confirm on rviz.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>

codecov · 2022-05-31T16:40:18Z

Codecov Report

Merging #1012 (4c834ef) into main (bf88d08) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1012      +/-   ##
========================================
- Coverage   9.66%   9.64%   -0.02%     
========================================
  Files        960     962       +2     
  Lines      64349   64471     +122     
  Branches   11183   11183              
========================================
  Hits        6217    6217              
- Misses     52969   53091     +122     
  Partials    5163    5163

Flag	Coverage Δ		*Carryforward flag
differential	`0.00% <0.00%> (?)`
total	`9.63% <ø> (ø)`		Carriedforward from 479106a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...sgs_converter/radar_tracks_msgs_converter_node.hpp	`0.00% <0.00%> (ø)`
...onverter_node/radar_tracks_msgs_converter_node.cpp	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf88d08...4c834ef. Read the comment docs.

Signed-off-by: scepter914 <scepter914@gmail.com>

...cks_msgs_converter/src/radar_tracks_msgs_converter_node/radar_tracks_msgs_converter_node.cpp

Signed-off-by: scepter914 <scepter914@gmail.com>

yukkysaito

LGTM

* add radar_tracks_msgs_converter Signed-off-by: scepter914 <scepter914@gmail.com> * apply format Signed-off-by: scepter914 <scepter914@gmail.com> * apply format Signed-off-by: scepter914 <scepter914@gmail.com> * fix compile error on autoware cmake Signed-off-by: scepter914 <scepter914@gmail.com> * fix namespace for cpplint Signed-off-by: scepter914 <scepter914@gmail.com> * fix for humble Signed-off-by: scepter914 <scepter914@gmail.com> * fix paramter copy Signed-off-by: scepter914 <scepter914@gmail.com> * update README Signed-off-by: scepter914 <scepter914@gmail.com> * add RadarTrackObjectID enum class Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

…ation#1012) * feat(autoware_launch): replace autoware_auto_mapping_msg with autoware_map_msg (autowarefoundation#688) feat(autoware_launch): remove autoware auto mapping msg Signed-off-by: liu cui <cynthia.liu@autocore.ai> * fix: planning_msg (autowarefoundation#717) fix:planning_msg Signed-off-by: jack.song <jack.song@autocore.ai> * feat(autoware_launch): replace autoware_control_msg with autoware_con… (autowarefoundation#725) feat(autoware_launch): replace autoware_control_msg with autoware_control_msg Signed-off-by: NorahXiong <norah.xiong@autocore.ai> * feat(autoware_launch): replace autoware_auto_vehicle_msgs with autoware_vehicle_msgs Signed-off-by: liu cui <cynthia.liu@autocore.ai> * fix(topics.yaml): fix AUTO button bug Signed-off-by: liu cui <cynthia.liu@autocore.ai> * feat(autoware_launch): rename autoware_auto_perception_rviz_plugin to autoware_perception_rviz_plugin Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * feat: rename TrafficSignal messages to TrafficLightGroup Signed-off-by: liu cui <cynthia.liu@autocore.ai> --------- Signed-off-by: liu cui <cynthia.liu@autocore.ai> Signed-off-by: jack.song <jack.song@autocore.ai> Signed-off-by: NorahXiong <norah.xiong@autocore.ai> Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> Co-authored-by: cyn-liu <104069308+cyn-liu@users.noreply.github.com> Co-authored-by: shulanbushangshu <102840938+shulanbushangshu@users.noreply.github.com> Co-authored-by: NorahXiong <103234047+NorahXiong@users.noreply.github.com> Co-authored-by: liu cui <cynthia.liu@autocore.ai> Co-authored-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

scepter914 added 6 commits May 31, 2022 22:25

add radar_tracks_msgs_converter

1e41747

Signed-off-by: scepter914 <scepter914@gmail.com>

apply format

496497b

Signed-off-by: scepter914 <scepter914@gmail.com>

apply format

0a161ff

Signed-off-by: scepter914 <scepter914@gmail.com>

Merge branch 'main' into feature/radar_tracks_msgs_converter

f2c1f8b

fix compile error on autoware cmake

4c2f52e

Signed-off-by: scepter914 <scepter914@gmail.com>

fix namespace for cpplint

16e0ace

Signed-off-by: scepter914 <scepter914@gmail.com>

scepter914 changed the title ~~feature: radar tracks msgs converter~~ feat: add radar tracks msgs converter May 31, 2022

fix for humble

479106a

Signed-off-by: scepter914 <scepter914@gmail.com>

scepter914 requested review from yukkysaito, aohsato and miursh June 1, 2022 07:21

scepter914 marked this pull request as ready for review June 1, 2022 07:21

yukkysaito reviewed Jun 1, 2022

View reviewed changes

...cks_msgs_converter/src/radar_tracks_msgs_converter_node/radar_tracks_msgs_converter_node.cpp Outdated Show resolved Hide resolved

yukkysaito reviewed Jun 1, 2022

View reviewed changes

...cks_msgs_converter/src/radar_tracks_msgs_converter_node/radar_tracks_msgs_converter_node.cpp Outdated Show resolved Hide resolved

yukke42 added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 2, 2022

scepter914 added 3 commits June 20, 2022 10:20

fix paramter copy

240f5dd

Signed-off-by: scepter914 <scepter914@gmail.com>

update README

605754a

Signed-off-by: scepter914 <scepter914@gmail.com>

add RadarTrackObjectID enum class

4c834ef

Signed-off-by: scepter914 <scepter914@gmail.com>

yukkysaito approved these changes Jun 20, 2022

View reviewed changes

scepter914 merged commit 488000a into autowarefoundation:main Jun 20, 2022

scepter914 deleted the feature/radar_tracks_msgs_converter branch June 20, 2022 09:18

tier4-autoware-public-bot bot mentioned this pull request Jun 21, 2022

chore: sync upstream tier4/autoware.universe#68

Merged

saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 28, 2023

fix(avoidance): fix avoidance path chattering (autowarefoundation#1012)

4db9994

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add radar tracks msgs converter #1012

feat: add radar tracks msgs converter #1012

scepter914 commented May 31, 2022 •

edited

Loading

codecov bot commented May 31, 2022 •

edited

Loading

yukkysaito left a comment

feat: add radar tracks msgs converter #1012

feat: add radar tracks msgs converter #1012

Conversation

scepter914 commented May 31, 2022 • edited Loading

Description

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented May 31, 2022 • edited Loading

Codecov Report

yukkysaito left a comment

Choose a reason for hiding this comment

scepter914 commented May 31, 2022 •

edited

Loading

codecov bot commented May 31, 2022 •

edited

Loading