Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_osqp_interface): porting autoware_osqp_interface package from autoware.universe #165

Conversation

NorahXiong
Copy link
Contributor

Description

Related links

Parent Issue: #164
Should be handled together with #9890

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…e from autoware.universe

Signed-off-by: NorahXiong <norah.xiong@autocore.ai>
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 51.62690% with 223 lines in your changes missing coverage. Please review.

Project coverage is 59.63%. Comparing base (4cb18f5) to head (b49425a).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...mon/autoware_osqp_interface/src/osqp_interface.cpp 42.40% 95 Missing and 15 partials ⚠️
...oware_osqp_interface/test/test_csc_matrix_conv.cpp 26.11% 1 Missing and 98 partials ⚠️
...toware_osqp_interface/test/test_osqp_interface.cpp 85.00% 1 Missing and 11 partials ⚠️
...include/autoware/osqp_interface/osqp_interface.hpp 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #165       +/-   ##
===========================================
- Coverage   78.75%   59.63%   -19.13%     
===========================================
  Files          11       16        +5     
  Lines         193      654      +461     
  Branches       73      364      +291     
===========================================
+ Hits          152      390      +238     
- Misses         11      110       +99     
- Partials       30      154      +124     
Flag Coverage Δ *Carryforward flag
differential 51.62% <51.62%> (?)
total 78.75% <ø> (ø) Carriedforward from 4cb18f5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NorahXiong NorahXiong requested a review from youtalk January 13, 2025 02:49
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r merged commit f59755c into autowarefoundation:main Jan 15, 2025
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants