Add a version variable in a standard way, update publishing script to account for the change, add new methods in Eva object #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charlesworth
reviewed
Jul 1, 2020
… account for the change, add new methods in Eva object
LouisBrunner
force-pushed
the
feature/user_agent
branch
from
d5d40dc to
698f7f3
Compare
Charlesworth
approved these changes
Jul 2, 2020
Charlesworth
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a custom User-Agent to all requests (format:
Automata EvaSDK/version (language/platform)).Because we include the version in the header, we also need to be able to access it outside
setup.py. I used the standard__version__notation and moved thesedreplacement to another file. The version will default to0.0.dev0when doing dev builds.I also added the 2 new functions added by Isaac in #58 and updated the headers.
This closes #59.