add no auth api call method. fix api versions bug. #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisBrunner
suggested changes
Jun 25, 2020
evasdk/eva_http_client.py
Outdated
| data=payload, headers=headers, | ||
| timeout=(timeout or self.request_timeout), | ||
| ) | ||
|
|
||
| # API VERSIONS | ||
| def api_versions(self): | ||
| r = self.__api_request('GET', 'versions') | ||
| r = self.__api_request('GET', 'versions', version=None) |
There was a problem hiding this comment.
Use your new api_call_no_auth? Maybe extend it to other functions which don't use auth?
evasdk/eva_http_client.py
Outdated
| headers = {'Authorization': 'Bearer {}'.format(self.session_token)} | ||
| headers = auth | ||
| else: | ||
| headers.update(auth) |
There was a problem hiding this comment.
That might mess with auth_create_session. Also I am not sure we should update arguments given as reference by a user?
There was a problem hiding this comment.
How would it mess wit auth_create_session? Doesn't it just get a session_token?
Wouldn't users always want the correct authentication to be added? Or are you saying that sometimes users may want to send a request with their own session token not attributed to the instance of EvaHTTPClient?
IsaacHook
force-pushed
the
feature/no_auth_and_api_versions_bug
branch
from
533c2b2 to
f0ba19b
Compare
LouisBrunner
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.