Add nginx and docker to supervisor with instructions to autostart #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
running Docker container
|
@nayak16 does this look good to merge? |
|
|
||
| # Define additional metadata for our image. | ||
| VOLUME /var/lib/docker | ||
| CMD ["wrapdocker"] |
There was a problem hiding this comment.
docker ps seems to work inside the docker container even without running this wrapper script so I feel more comfortable leaving it out. It seems to be a wrapper to start docker, which won't work in the Dockerfile anyways since you can only run one command at the end of the Dockerfile to be run in the container.
As an alternative, I can set wrapdocker as the process to start in supervisor instead of Docker itself, which will ensure that wrapdocker runs (and thus will start Docker). Is this preferred?
|
Let's merge this. It looks good |
|
Closed by b452d05 |
This was referenced Sep 21, 2020
Closed
This was referenced Dec 11, 2020
Closed
This was referenced Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses some parts of #121. More specifically, it adds nginx and docker to supervisor. Exposing the ports of the Tango service in the docker container simply involves adding extra params when running the docker container so that has been added to the suggested deployment documentation.