Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix installing nodejs deps in the tests #973

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

aleksuss
Copy link
Member

Description

The PR fixes breaking tests that are related to the execution in the CI only.

@aleksuss aleksuss requested a review from mrLSD as a code owner November 12, 2024 13:51
@aleksuss
Copy link
Member Author

Sorry, guys, for the changes after review, but I guess I realised that file lock is redundant here because it looks like the target folder in the root project folder can't be shared between processes that execute the tests. It seems the problem was related to the directory engine-tests/target. Anyway, the issue isn't reproduced after changing the source_dir from engine-tests/target to the target.

@aleksuss aleksuss enabled auto-merge November 12, 2024 21:11
@aleksuss aleksuss added this pull request to the merge queue Nov 12, 2024
Merged via the queue into develop with commit 6562440 Nov 12, 2024
25 checks passed
@aleksuss aleksuss deleted the ci/aleksuss/fix_yarn_install branch November 12, 2024 21:12
aleksuss added a commit that referenced this pull request Feb 5, 2025
## Description

The PR fixes breaking tests that are related to the execution in the CI
only.
@aleksuss aleksuss mentioned this pull request Feb 5, 2025
aleksuss added a commit that referenced this pull request Feb 5, 2025
## [3.8.0] 2025-02-05

### Changes

- Bumped the SputnikVM up to 0.46.1-aurora by [@mrLSD]. ([#966])
- The nightly rust compiler has been replaced with stable by
[@aleksuss]. ([#977])
- Added changes regarding bumping the `primitive-types` crate by
[@mrLSD]. ([#982])
- The code coverage by clippy has been extended by [@aleksuss]. ([#984])
- The code is changed by the clippy suggestions from the toolchain
1.84.0 by [@mrLSD]. ([#986])
- The precompile `exitToNear` now is compatible with the OMNI bridge by
[@aleksuss]. ([#992])

### Fixes

- Added optimisations to the `AccountId` creation methods by
[@aleksuss]. ([#985])
- The `README.md` has been actualized by [@aleksuss]. ([#978])
- Modified CI scripts by [@aleksuss]. ([#969], [#973], [#975], [#976],
[#981])
- Fixed the vulnerability in the `remove_relayer_key` transaction by
[@aleksuss]. ([#972])

[#966]: #966
[#969]: #969
[#972]: #972
[#973]: #973
[#975]: #975
[#976]: #976
[#977]: #977
[#978]: #978
[#981]: #981
[#982]: #982
[#984]: #984
[#985]: #985
[#986]: #986
[#992]: #992

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: cuibuwei <cuibuwei@gmail.com>
Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev>
Co-authored-by: omahs <73983677+omahs@users.noreply.github.com>
Co-authored-by: Elias Rad <146735585+nnsW3@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: cuibuwei <166905851+cuibuwei@users.noreply.github.com>
Co-authored-by: NotNotARobot <164791169+NotNotARobot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants