fix: add relayer function call key vulnerability #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
approved these changes
Nov 8, 2024
mrLSD
approved these changes
Nov 8, 2024
aleksuss
added a commit
that referenced
this pull request
Feb 5, 2025
## Description The PR fixes the vulnerability, which allows the removal of the full access key from the engine's account ID. ## Performance / NEAR gas cost considerations No performance chages. ## Testing The corresponding test has been added. ## Additional information Thanks to @mitinarseny for pointing it out.
Merged
aleksuss
added a commit
that referenced
this pull request
Feb 5, 2025
## [3.8.0] 2025-02-05 ### Changes - Bumped the SputnikVM up to 0.46.1-aurora by [@mrLSD]. ([#966]) - The nightly rust compiler has been replaced with stable by [@aleksuss]. ([#977]) - Added changes regarding bumping the `primitive-types` crate by [@mrLSD]. ([#982]) - The code coverage by clippy has been extended by [@aleksuss]. ([#984]) - The code is changed by the clippy suggestions from the toolchain 1.84.0 by [@mrLSD]. ([#986]) - The precompile `exitToNear` now is compatible with the OMNI bridge by [@aleksuss]. ([#992]) ### Fixes - Added optimisations to the `AccountId` creation methods by [@aleksuss]. ([#985]) - The `README.md` has been actualized by [@aleksuss]. ([#978]) - Modified CI scripts by [@aleksuss]. ([#969], [#973], [#975], [#976], [#981]) - Fixed the vulnerability in the `remove_relayer_key` transaction by [@aleksuss]. ([#972]) [#966]: #966 [#969]: #969 [#972]: #972 [#973]: #973 [#975]: #975 [#976]: #976 [#977]: #977 [#978]: #978 [#981]: #981 [#982]: #982 [#984]: #984 [#985]: #985 [#986]: #986 [#992]: #992 --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: cuibuwei <cuibuwei@gmail.com> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com> Co-authored-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: cuibuwei <166905851+cuibuwei@users.noreply.github.com> Co-authored-by: NotNotARobot <164791169+NotNotARobot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes the vulnerability, which allows the removal of the full access key from the engine's account ID.
Performance / NEAR gas cost considerations
No performance chages.
Testing
The corresponding test has been added.
Additional information
Thanks to @mitinarseny for pointing it out.