Review #1
Review #1
Conversation
core/src/main/java/me/aurium/beetle/branch/adapter/ContextAdapter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/me/aurium/beetle/branch/annotate/AnnotatedCommand.java
Outdated
Show resolved
Hide resolved
| @@ -6,8 +6,12 @@ | |||
| <sourceOutputDir name="target/generated-sources/annotations" /> | |||
| <sourceTestOutputDir name="target/generated-test-sources/test-annotations" /> | |||
| <outputRelativeToContentRoot value="true" /> | |||
| <module name="core" /> | |||
There was a problem hiding this comment.
Use .gitignore for these files
core/src/main/java/me/aurium/beetle/branch/adapter/ContextAdapter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/me/aurium/beetle/branch/block/CommonBlockPath.java
Outdated
Show resolved
Hide resolved
tests/src/test/java/me/aurium/beetle/branch/tests/AbstractTests.java
Outdated
Show resolved
Hide resolved
core/src/main/java/me/aurium/beetle/branch/block/BlockList.java
Outdated
Show resolved
Hide resolved
| protected final static String ALIAS = "TestCommand"; | ||
|
|
||
| //@A248 is there a better way to do this with junit5? i'm not used to it. Is ther also a way to make the logger messages less ugly? They look shitty compared to juni4 | ||
| protected void logTestStarting(String name) { |
There was a problem hiding this comment.
| protected void logTestStarting(String name) { | |
| @BeforeEach | |
| public void logTestStarting() { | |
| logger.info("Starting test {}", getClass().getName()); | |
| } |
|
|
||
| //@A248 is there a better way to do this with junit5? i'm not used to it. Is ther also a way to make the logger messages less ugly? They look shitty compared to juni4 | ||
| protected void logTestStarting(String name) { | ||
| logger.info(() -> "(BRANCH) Beginning test: " + name); |
There was a problem hiding this comment.
I don't know why you're using org.junit.platform.commons.logging - that's internal API from junit-platform-commons. Your IDE should warn you such package is encapsulated. Maybe it's because you need to add module-info to Branch.
If you use slf4j, to format its log messages you have to configure the slf4j implementation. If that's slf4j-simple, make a simplelogger.properties and follow the slf4j-simple docs.
There was a problem hiding this comment.
Hmm, interesting. I tried slf4j with junit5 once and it didn't work which is why i defaulted to looking for a platform specific logger, but that makes much more sense
There was a problem hiding this comment.
It works fine. What "didn't work" about it?
There was a problem hiding this comment.
What didn't work was nothing was logged.
Co-authored-by: A248 <anandebeh@gmail.com>
# Conflicts: # core/pom.xml
|
oops hold on it doesnt seem to have pushed |
beetle-impl/pom.xml
Outdated
| </dependency> | ||
| <dependency> | ||
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-core</artifactId> |
There was a problem hiding this comment.
Why are you using logback? Why were you previously using log4j2? A library should not depend on a concrete logging framework
There was a problem hiding this comment.
This is for testing, remember. the scope is test.
| * yet another marker interface | ||
| * @param <C> | ||
| */ | ||
| public interface AloneBuilder<C> extends Builder<C> { |
core/src/main/java/me/aurium/beetle/branch/handlers/EmptySuggestionHandler.java
Outdated
Show resolved
Hide resolved
|
|
||
| private T alreadyStored; | ||
| private final Set<T> otherThingsInTheSet; | ||
| private final boolean linked; | ||
|
|
||
| //fuck code in the constructor rules |
There was a problem hiding this comment.
There's no code in the constructor here?
There was a problem hiding this comment.
oh thats a remnant from a while ago, there used to be a bit of code there
# Conflicts: # pom.xml
…vertet.java Co-authored-by: A248 <anandebeh@gmail.com>
Add adapters and improve queue system
Fix block, add docs
|
Kudos, SonarCloud Quality Gate passed!
|
|
cum |
Review