Feature Request: Remove the minimum Window size requirements.#107
Merged
josselinonduty merged 3 commits intomasterfrom Apr 14, 2025
Merged
Feature Request: Remove the minimum Window size requirements.#107josselinonduty merged 3 commits intomasterfrom
josselinonduty merged 3 commits intomasterfrom
Conversation
Collaborator
Author
|
Also Fixes #104 |
Owner
|
Looks good to me thanks! |
aunetx
approved these changes
Apr 11, 2025
randshell
approved these changes
Apr 14, 2025
aunetx
added a commit
that referenced
this pull request
May 21, 2025
This is an improvement over #107, to make the application entirely responsive (up t a certain point, but which should not be encountered even on mobile). Most changes are either very small or only permit a seamless compatibility with low-width displays; the three only "big" changes happening are: - under 800 pixels wide, the bottom playing bar elements see their relative width change a bit, to allow give enough space for the song name and player control, without having a big blank space on the right - under 950 pixels wide, the queue tracks list has less margin, to allow to fit way more of the song names - under 750 pixels wide, the current song's cover and name is hidden from the left of the queue tracks list: this permits to continue fitting the content, and this information is redundant anyway as it is show on the bottom playing bar already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105
Changes minimum size requirements and allow scrolling when CSS breaks.
With smaller dimensions, some content is unreachable like the playlist scroll bar on the left, and it is not straightforward to change its behaviour with CSS.