Standardize DB Job names #139
Conversation
It also makes two other changes: * Moves the entrypoint container manifest snippet to its own file to reduce loading on the _funcs.tpl file * Changes dep-check-init-cont to dep_check_init_cont to match the formatting of other defines used in OpenStack Helm
Brings Neutron inline with other services, by moving the dependency checks to an init-container.
Standardise the DB creation job name to service-db-init for all services.
alanmeadows
left a comment
alanmeadows
left a comment
There was a problem hiding this comment.
@intlabs This seems like a welcomed cleanup to me. Nice work.
|
looks good to me |
v1k0d3n
left a comment
v1k0d3n
left a comment
There was a problem hiding this comment.
Thank your for catching these and for all the cleanup work! @intlabs if you find other things like this, or even identify them (and don't have time for them), create an issue when you see them. This way, we can flag them as "starter" items to help people get started. But as long as you keep finding them and cleaning them up...that works too!
| containers: | ||
| - name: glance-init | ||
| image: {{ .Values.images.init }} | ||
| - name: glance-db-init |
There was a problem hiding this comment.
good catch on these. good work.
| - name: glance-init | ||
| image: {{ .Values.images.init }} | ||
| - name: glance-db-init | ||
| image: {{ .Values.images.db_init }} |
There was a problem hiding this comment.
again, defining the assumed vars better. nice.
| @@ -0,0 +1,32 @@ | |||
| {{- $envAll := . }} | |||
There was a problem hiding this comment.
this is in line with your other cleanup work. nice job separating these like your other recent commits.
4 participants
Standardize the DB creation job name to -db-init for all services.
Builds on the following which should be reviewed/merged first:
This change is