This repository was archived by the owner on Jul 24, 2019. It is now read-only.
Add support for daemonsets to the Kubernetes-Entrypoint init-container. #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also makes two other changes: * Moves the entrypoint container manifest snippet to its own file to reduce loading on the _funcs.tpl file * Changes dep-check-init-cont to dep_check_init_cont to match the formatting of other defines used in OpenStack Helm
This was referenced Jan 22, 2017
alanmeadows
approved these changes
Jan 24, 2017
Contributor
alanmeadows
left a comment
alanmeadows
left a comment
There was a problem hiding this comment.
@intlabs This seems like a good change to me, and gets us further towards normalizing some function names.
I would of liked to have seen the function become more verbose (e.g. dependency_check_init_container) and even adopt your own suggestion of chartName.func but we can do that on another pass.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also makes two other changes:
This change is