Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add become: yes to playbook example #27

Merged
merged 2 commits into from
May 28, 2019
Merged

Add become: yes to playbook example #27

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6cb5c9
Add become: yes to playbook example
till Dec 6, 2018
5d38c20
Update: become on playbook level
till May 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ None.
- name: "Install Minio"
hosts: all
roles:
- atosatto.minio
- { role: atosatto.minio, become: yes }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I would just put this at the playbook level, rather than at the role level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no stake. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperQ thoughts about merging this example, or no?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@till would you mind changing it to something like

- name: "Install Minio"
  hosts: all
  become: yes
  roles:
    - { role: atosatto.minio }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atosatto Of course not! (Done ✅)

vars:
minio_server_datadirs: [ "/minio-test" ]
```
Expand Down