Add become: yes to playbook example #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the example doesn't include a hint that you need to be root. It's sort of obvious since the role attempts to create a minio user and group, but I figured I add it to make it easier for the next person.
SuperQ
reviewed
Dec 6, 2018
README.md
Outdated
| @@ -115,7 +115,7 @@ None. | |||
| - name: "Install Minio" | |||
| hosts: all | |||
| roles: | |||
| - atosatto.minio | |||
| - { role: atosatto.minio, become: yes } | |||
There was a problem hiding this comment.
Normally I would just put this at the playbook level, rather than at the role level.
There was a problem hiding this comment.
@SuperQ thoughts about merging this example, or no?
There was a problem hiding this comment.
@till would you mind changing it to something like
- name: "Install Minio"
hosts: all
become: yes
roles:
- { role: atosatto.minio }
There was a problem hiding this comment.
@atosatto Of course not! (Done ✅)
atosatto
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the example doesn't include a hint that you need to be root. It's sort of obvious since the role attempts to create a minio user and group, but I figured I add it to make it easier for the next person.